1253420 - Test failure possibly due to working translations

Status: RESOLVED WONTFIX

(support.mozilla.org :: Code Quality, task)

Description

[Osmose [:osmose, :mkelly]]

When running the tests locally, I get the following failure: 

======================================================================
FAIL: The document template falls back to fallback locale if there is
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/mkelly/Projects/kitsune/kitsune/wiki/tests/test_templates.py", line 414, in test_document_with_fallback_locale
    assert 'Translate Article' in doc('#editing-tools-sidebar').text()
AssertionError 

----------------------------------------------------------------------

It looks like the test is asserting that an English string is in a bn-BD document. When I run it with a locale directory with translations in it, it fails, but when I run it without a locale directory, it passes. It should pass regardless of whether a locale directory is present.

Comment 1

[Safwan Rahman (:safwan)]

(In reply to Michael Kelly [:mkelly,:Osmose] from comment #0)
> When running the tests locally, I get the following failure: 
> 
> ======================================================================
> FAIL: The document template falls back to fallback locale if there is
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File
> "/Users/mkelly/Projects/kitsune/kitsune/wiki/tests/test_templates.py", line
> 414, in test_document_with_fallback_locale
>     assert 'Translate Article' in doc('#editing-tools-sidebar').text()
> AssertionError 
> 
> ----------------------------------------------------------------------
> 
> It looks like the test is asserting that an English string is in a bn-BD
> document. When I run it with a locale directory with translations in it, it
> fails, but when I run it without a locale directory, it passes. It should
> pass regardless of whether a locale directory is present.

Sorry from my end. This test was written while the "fallback locale" feature which was implemented by me. 
In the feature, we need to check that there are "Translate Article" button instead of "Edit Article" button as the article is showing in fallback locale. It was in "acceptance criteria"

Do you have any idea what the test should be? So that is passes regardless a locale directory present or not. Let me know if I can help any regarding it.

Comment 2

[Osmose [:osmose, :mkelly]]

(In reply to Safwan Rahman from comment #1)
> Do you have any idea what the test should be? So that is passes regardless a
> locale directory present or not. Let me know if I can help any regarding it.

The test should probably check for something that is independent of the translations; for example, if the edit article and translate article buttons have different classes, you can test for that.

Comment 3

[Seburo]

Closed as per https://blog.mozilla.org/sumo/2019/06/07/sumo-platform-roadmap/