1253438 - Expose observer notification names on `nsIPushService`

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Lina Butler [:lina]]

Technically, they're related to `nsIPushNotifier`...but that would require consumers to import two services, and `nsIPushNotifier` is an internal interface that only supports `PushService.jsm`.

Comment 1

[Lina Butler [:lina]]

Attachment: MozReview Request: Bug 1253438 - Expose Push observer notification topics. r?markh

Review commit: https://reviewboard.mozilla.org/r/38005/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38005/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8726451 [details]
MozReview Request: Bug 1253438 - Expose Push observer notification topics. r?markh

https://reviewboard.mozilla.org/r/38005/#review34563

Loogs good to me. Note I'm not a DOM peer, so I'm probably not technically able to r+ this, but given the changes are all in dom/push and you are requesting review, it's probably fine.

::: dom/push/PushComponents.js:19
(Diff revision 1)
> +const OBSERVER_TOPIC_PUSH = "push-message";

I think it's probably worth a comment indicating that these constants are duplicated in PushNotifier.cpp (avoiding the duplication is probably possible if PushNotifier got a handle to the push service, but I don't think we need to bother with that).  Ditto in the .cpp (ie, a comment noting the constants are duplicated in the .js)

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/65955cf5a546

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/65955cf5a546