1253456 - Disable rust on win32

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

Temporarily remove --enable-rust from win32 mozconfigs until we can address bug 1253202.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Disable rust on win32

I'm not going to get a custom library build ready for testing in time for the next nightly, so work around the top-crash in the meantime by disabling the code.

This leaves rust enabled for debug builds for testing convenience.

Comment 2

[Alex Crichton [:acrichto]]

Given that bug 1253202 was probably caused by the same thing bug 1252041 was caused by (using SSE2 instructions), then it's probably worth pointing out that the standard library has SSE2 enabled by default on all platforms I believe (e.g. including Linux/OSX). It looks like the only crash reports came from Windows, though? If any Linux/OSX user uses one of those old CPUs though they're likely to see the same crash.

Just FYI!

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8726471 [details] [diff] [review]
Disable rust on win32

Looks fine. We can always disable it in other platforms if they exhibit the crash as well. It wasn't seen it all in win64?

Comment 4

[Alex Crichton [:acrichto]]

I believe x86_64 by definition has SSE2, it's just x86 that may or may not have SSE2. (I may be remembering wrong though)

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

OS X for x86 requires at least Core 2, so SSE2 is never an issue. I heard we have enabled SSE2 for Linux 32bit since long ago?

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/530047c97d83

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/530047c97d83