Remove --with-wrap-malloc and --enable-wrap-malloc

RESOLVED FIXED in Firefox 48

Status

()

Core
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks: 1 bug)

unspecified
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Same reason as in bug 1080341, but apply to js/src, this time.
(Assignee)

Comment 1

2 years ago
Created attachment 8726493 [details]
MozReview Request: Bug 1253464 - Remove --enable-wrap-malloc/--with-wrap-malloc from js/src/old-configure.in

for the same reason as they were removed in bug 1080341 for the
top-level, and the additional reason that configure.py doesn't support
--enable and --with options with the same name.

Review commit: https://reviewboard.mozilla.org/r/38055/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38055/
Attachment #8726493 - Flags: review?(mshal)
Comment on attachment 8726493 [details]
MozReview Request: Bug 1253464 - Remove --enable-wrap-malloc/--with-wrap-malloc from js/src/old-configure.in

https://reviewboard.mozilla.org/r/38055/#review34701

Looks good, the single issue could be a followup if it is indeed unused.

::: js/src/old-configure.in
(Diff revision 1)
> -    WRAP_LDFLAGS="${WRAP_LDFLAGS} $withval")

Do we still have a need for WRAP_LDFLAGS (like manually specifying them in the mozconfig, or something?)

It looks like we can remove the AC_SUBST(WRAP_LDFLAGS) from here and the top-level old-configure.in, as well as the usage in config/rules.mk and config/external/nss/Makefile.in
Attachment #8726493 - Flags: review?(mshal) → review+
(Assignee)

Updated

2 years ago
Blocks: 1254351

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/33848fe94084

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/33848fe94084
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.