Closed Bug 1253529 Opened 8 years ago Closed 8 years ago

remove the 'grid-template' shorthand

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: dbaron, Assigned: MatsPalmgren_bugz)

References

Details

(Keywords: css3)

Attachments

(2 files)

As discussed in https://lists.w3.org/Archives/Public/www-style/2016Feb/0332.html and resolved in https://logs.csswg.org/irc.w3.org/css/2016-03-02/#e660099 the CSS WG has agreed to remove the 'grid-template' shorthand property.  We should remove our implementation.
Flags: needinfo?(mats)
Thanks for the update.
Assignee: nobody → mats
Blocks: 1217086
Flags: needinfo?(mats)
Priority: -- → P3
I moved all the 'grid-template' shorthand tests to be tests on 'grid' instead.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8b20f2c1374&selectedJob=17649285
Attachment #8727377 - Flags: review?(dholbert)
Comment on attachment 8727377 [details] [diff] [review]
Remove the 'grid-template' shorthand.

Review of attachment 8727377 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, one nit:

::: layout/style/test/test_grid_shorthand_serialization.html
@@ +25,5 @@
>      gridRowGap: "0px",
>      gridColumnGap: "0px",
>  };
>  
> +// For various specified values of the 'grid' subproperties,

This test's title needs an update, too. Right now the <title> is:
  <title>Test serialization of CSS Grid shorthand properties</title>

That probably needs tweaking like so:
  Grid shorthand properties ==>
  'grid' shorthand property
Attachment #8727377 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/620254a752b1
https://hg.mozilla.org/mozilla-central/rev/1ef9659595f7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
(FWIW: there's some discussion at the CSSWG about maaaybe bringing this shorthand back again, but it seems more likely that it'll stay removed. See grid-template section at https://lists.w3.org/Archives/Public/www-style/2016Apr/0093.html )
So the group just decided to undo this decision and put grid-template back in the spec.  So it seems this should be backed out.
Flags: needinfo?(mats)
Blocks: 1266250
Filed bug 1266250.
Flags: needinfo?(mats)
You need to log in before you can comment on or make changes to this bug.