Closed
Bug 1253534
Opened 8 years ago
Closed 8 years ago
Suspicious code with probably reversed parms in call to IsSingleLineTextControl(bool, uint32_t)
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: capella, Assigned: capella)
Details
Attachments
(1 file)
|
1.21 KB,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
Spotted here [0] and blamed on bug 665655 [0] http://mxr.mozilla.org/mozilla-central/source/dom/html/HTMLInputElement.cpp?mark=4360-4361#4352
|
Assignee | |
Updated•8 years ago
|
Flags: needinfo?(mounir)
|
|
Assignee | |
Comment 1•8 years ago
|
||
Looks obvious, review?
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Flags: needinfo?(mounir)
Attachment #8726614 -
Flags: review?(mounir)
|
||
Comment 2•8 years ago
|
||
We should probably leave something behind to prevent future errors too, e.g.: static bool IsSingleLineTextControl(uint32_t, bool) = delete; I'm worried that we more of this kind of error in the tree, so I filed bug 1253844 to see if static analysis can help.
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8726614 [details] [diff] [review] bug1253534.diff Review of attachment 8726614 [details] [diff] [review]: ----------------------------------------------------------------- r+, thanks for fixing this! :)
Attachment #8726614 -
Flags: review?(mounir) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
Usual quick TRY push https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1188be9c95b
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/54abddb1c44c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•