Closed Bug 1253534 Opened 5 years ago Closed 5 years ago

Suspicious code with probably reversed parms in call to IsSingleLineTextControl(bool, uint32_t)

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: capella, Assigned: capella)

Details

Attachments

(1 file)

Flags: needinfo?(mounir)
Attached patch bug1253534.diffSplinter Review
Looks obvious, review?
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Flags: needinfo?(mounir)
Attachment #8726614 - Flags: review?(mounir)
We should probably leave something behind to prevent future errors too, e.g.:
static bool IsSingleLineTextControl(uint32_t, bool) = delete;

I'm worried that we more of this kind of error in the tree,
so I filed bug 1253844 to see if static analysis can help.
Comment on attachment 8726614 [details] [diff] [review]
bug1253534.diff

Review of attachment 8726614 [details] [diff] [review]:
-----------------------------------------------------------------

r+, thanks for fixing this! :)
Attachment #8726614 - Flags: review?(mounir) → review+
https://hg.mozilla.org/mozilla-central/rev/54abddb1c44c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.