1253534 - Suspicious code with probably reversed parms in call to IsSingleLineTextControl(bool, uint32_t)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mark Capella [:capella]]

Spotted here [0] and blamed on bug 665655

[0] http://mxr.mozilla.org/mozilla-central/source/dom/html/HTMLInputElement.cpp?mark=4360-4361#4352

Comment 1

[Mark Capella [:capella]]

Attachment: bug1253534.diff

Looks obvious, review?

Comment 2

[Mats Palmgren (inactive)]

We should probably leave something behind to prevent future errors too, e.g.:
static bool IsSingleLineTextControl(uint32_t, bool) = delete;

I'm worried that we more of this kind of error in the tree,
so I filed bug 1253844 to see if static analysis can help.

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 8726614 [details] [diff] [review]
bug1253534.diff

Review of attachment 8726614 [details] [diff] [review]:
-----------------------------------------------------------------

r+, thanks for fixing this! :)

Comment 4

[Mark Capella [:capella]]

Usual quick TRY push
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1188be9c95b

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/54abddb1c44c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/54abddb1c44c