Suspicious code with probably reversed parms in call to IsSingleLineTextControl(bool, uint32_t)

RESOLVED FIXED in Firefox 47

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: capella, Assigned: capella)

Tracking

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Updated

3 years ago
Flags: needinfo?(mounir)
(Assignee)

Comment 1

3 years ago
Created attachment 8726614 [details] [diff] [review]
bug1253534.diff

Looks obvious, review?
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Flags: needinfo?(mounir)
Attachment #8726614 - Flags: review?(mounir)
We should probably leave something behind to prevent future errors too, e.g.:
static bool IsSingleLineTextControl(uint32_t, bool) = delete;

I'm worried that we more of this kind of error in the tree,
so I filed bug 1253844 to see if static analysis can help.
Comment on attachment 8726614 [details] [diff] [review]
bug1253534.diff

Review of attachment 8726614 [details] [diff] [review]:
-----------------------------------------------------------------

r+, thanks for fixing this! :)
Attachment #8726614 - Flags: review?(mounir) → review+

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/54abddb1c44c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.