Closed
Bug 1253571
Opened 8 years ago
Closed 8 years ago
MozMtpDatabase.cpp:817:3: error: 'ScopedDeletePtr' was not declared in this scope
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(firefox47 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: gwagner, Assigned: gsvelto)
References
Details
Attachments
(1 file)
5.84 KB,
patch
|
dhylands
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•8 years ago
|
Assignee | ||
Comment 2•8 years ago
|
||
Bug 1252902 broke a bunch of stuff in HAL too; I'm also fixing that in this bug.
Assignee | ||
Comment 3•8 years ago
|
||
This patch uses UniquePtr and UniqueFreePtr to replace the remaining instances of ScopedDeletePtr and ScopedFreePtr.
Attachment #8726720 -
Flags: review?(dhylands)
Comment 4•8 years ago
|
||
Comment on attachment 8726720 [details] [diff] [review] [PATCH] Remove the remaining uses of ScopedDeletePtr and ScopedFreePtr from the HAL and MTP code Review of attachment 8726720 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #8726720 -
Flags: review?(dhylands) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Thanks for the quick review Dave. Try run is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b756b4421ec Will land on inbound as soon as it gets re-opened.
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3f727688f71f
You need to log in
before you can comment on or make changes to this bug.
Description
•