Closed
Bug 1253598
Opened 8 years ago
Closed 8 years ago
Disable offline cache feature on release
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox46 fixed, firefox47 fixed, firefox48 fixed, fennec46+)
RESOLVED
FIXED
Firefox 48
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(2 files)
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details |
67 bytes,
text/x-github-pull-request
|
sebastian
:
review+
|
Details | Review |
Given that we don't know what's happening in bug 1236130, let's disable this offline cache feature for release. We could actually control this with a Switchboard flag, given that we created a pattern for controlling gecko prefs with Switchboard over in bug 1241566.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → margaret.leibovic
Updated•8 years ago
|
tracking-fennec: ? → 46+
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/39277/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/39277/
Attachment #8729170 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8729171 -
Flags: review?(s.kaspari)
Comment 3•8 years ago
|
||
Comment on attachment 8729170 [details] MozReview Request: Bug 1253598 - Put offline cache feature behind a switchboard flag. r=sebastian https://reviewboard.mozilla.org/r/39277/#review36131 We can enable this preference via the experiment. But there's no way to disable it again, right? So even after disabling the experiment we might have users with that (potentially buggy) feature on?
Attachment #8729170 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Sebastian Kaspari (:sebastian) from comment #3) > Comment on attachment 8729170 [details] > MozReview Request: Bug 1253598 - Put offline cache feature behind a > switchboard flag. r=sebastian > > https://reviewboard.mozilla.org/r/39277/#review36131 > > We can enable this preference via the experiment. But there's no way to > disable it again, right? So even after disabling the experiment we might > have users with that (potentially buggy) feature on? No, this isn't the case because we're setting this pref on the default branch. The way these gecko default prefs work is that we're overriding the default here. If this code isn't executed, we fall back to the value defined in mobile.js. Alternately, if the user has set their own value, that will take precedence. This is similar to what we do for distributions.
Updated•8 years ago
|
Attachment #8729171 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/20ede8c80073eea92373bd27604c9ae84aa82488 Bug 1253598 - Put offline cache feature behind a switchboard flag. r=sebastian
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8729170 [details] MozReview Request: Bug 1253598 - Put offline cache feature behind a switchboard flag. r=sebastian Approval Request Comment [Feature/regressing bug #]: Due to bug 1236130, we want to prevent this from automatically riding to release. [User impact if declined]: Sometimes sites won't update (bug 1236130). [Describe test coverage new/current, TreeHerder]: No automated test coverage, verified locally this flips the pref properly. [Risks and why]: Low-risk pref flip. This adds a bit more complexity than normal due to putting this behind a switchboard flag, but if switchboard fails, this pref will just be disabled by default. [String/UUID change made/needed]: None.
Attachment #8729170 -
Flags: approval-mozilla-beta?
Attachment #8729170 -
Flags: approval-mozilla-aurora?
Comment 7•8 years ago
|
||
Comment on attachment 8729170 [details] MozReview Request: Bug 1253598 - Put offline cache feature behind a switchboard flag. r=sebastian Sounds good to be able to turn off this feature from Switchboard, OK to uplift.
Attachment #8729170 -
Flags: approval-mozilla-beta?
Attachment #8729170 -
Flags: approval-mozilla-beta+
Attachment #8729170 -
Flags: approval-mozilla-aurora?
Attachment #8729170 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 8•8 years ago
|
||
FYI, once this patch is uplifted, we don't need to make any other Switchboard config change. There will be no noticeable difference on beta, but the feature won't make it to release.
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/20ede8c80073
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment 10•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/854a8a7e9606
status-firefox47:
--- → fixed
Comment 11•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/cfd269a9ec35
status-firefox46:
--- → fixed
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•