Implement browser.extension.isAllowedIncognitoAccess

RESOLVED FIXED in Firefox 48

Status

()

Toolkit
WebExtensions: Untriaged
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: andym, Assigned: cgrebs, Mentored)

Tracking

({dev-doc-complete})

unspecified
mozilla48
dev-doc-complete
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [extension][good first bug][berlin])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
As per https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/Extension/isAllowedIncognitoAccess
For the moment, this can just be a stub that returns `true`, since we currently allow incognito access to all extensions.
Mentor: kmaglione+bmo@mozilla.com
Summary: Implement chrome.extension.isAllowedIncognitoAccess → Implement browser.extension.isAllowedIncognitoAccess
Whiteboard: [extension][good first bug][berlin]
Keywords: dev-doc-needed

Comment 2

2 years ago
Hello,

I would like to work on this bug. Can you please give me some hint since this is my first bug?
Flags: needinfo?(kmaglione+bmo)
(Assignee)

Updated

2 years ago
Assignee: nobody → cgrebs
Status: NEW → ASSIGNED
(Assignee)

Comment 3

2 years ago
Created attachment 8730152 [details]
MozReview Request: Bug 1253645 - Implement browser.extension.isAllowedIncognitoAccess, r?kmag

Review commit: https://reviewboard.mozilla.org/r/39711/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39711/
Attachment #8730152 - Flags: review?(kmaglione+bmo)
(Assignee)

Comment 4

2 years ago
Need to update https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/Extension/isAllowedIncognitoAccess once review is done.
Comment on attachment 8730152 [details]
MozReview Request: Bug 1253645 - Implement browser.extension.isAllowedIncognitoAccess, r?kmag

https://reviewboard.mozilla.org/r/39711/#review36337

::: toolkit/components/extensions/test/mochitest/test_ext_extension.html:19
(Diff revision 1)
> +"use strict";
> +
> +add_task(function* test_is_allowed_incognito_access() {
> +  function backgroundScript() {
> +    browser.extension.isAllowedIncognitoAccess().then(isAllowedIncognitoAccess => {
> +      browser.test.assertTrue(isAllowedIncognitoAccess, `isAllowedIncognitoAccess is true`);

Please use `assertEq(true, isAllowedIncognitoAccess, ...)` instead, since we want to test against the exact value `true`, rather than just a value which evaluates as true.

::: toolkit/components/extensions/test/mochitest/test_ext_extension.html:20
(Diff revision 1)
> +
> +add_task(function* test_is_allowed_incognito_access() {
> +  function backgroundScript() {
> +    browser.extension.isAllowedIncognitoAccess().then(isAllowedIncognitoAccess => {
> +      browser.test.assertTrue(isAllowedIncognitoAccess, `isAllowedIncognitoAccess is true`);
> +      browser.test.notifyPass("ready");

Please use a more specific name for the result than "pass", like "isAllowedIncognitoAccess"
Attachment #8730152 - Flags: review?(kmaglione+bmo) → review+
(Assignee)

Comment 6

2 years ago
Comment on attachment 8730152 [details]
MozReview Request: Bug 1253645 - Implement browser.extension.isAllowedIncognitoAccess, r?kmag

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39711/diff/1-2/
(Assignee)

Updated

2 years ago
Whiteboard: [extension][good first bug][berlin] → [extension][good first bug][berlin][checkin-needed]
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
Whiteboard: [extension][good first bug][berlin][checkin-needed] → [extension][good first bug][berlin]

Updated

2 years ago
Flags: needinfo?(kmaglione+bmo)

Comment 7

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a689a66e9e8e
Keywords: checkin-needed

Comment 8

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc205e345b60
Pushed a follow-up which adds a semicolon at the end of a single statement function so eslint stops complaining:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc205e345b60

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a689a66e9e8e
https://hg.mozilla.org/mozilla-central/rev/fc205e345b60
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
https://hg.mozilla.org/integration/fx-team/rev/cf51b4c7b52eee273b054a363934adde7ec597f5
Bug 1253645: Follow-up: Fix ESLint errors. r=me

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cf51b4c7b52e
-> https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/extension/isAllowedIncognitoAccess#Browser_compatibility
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.