Closed
Bug 1253645
Opened 8 years ago
Closed 8 years ago
Implement browser.extension.isAllowedIncognitoAccess
Categories
(WebExtensions :: Untriaged, defect)
WebExtensions
Untriaged
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: andy+bugzilla, Assigned: cgrebs, Mentored)
References
Details
(Keywords: dev-doc-complete, Whiteboard: [extension][good first bug][berlin])
Attachments
(1 file)
As per https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/Extension/isAllowedIncognitoAccess
Comment 1•8 years ago
|
||
For the moment, this can just be a stub that returns `true`, since we currently allow incognito access to all extensions.
Mentor: kmaglione+bmo
Summary: Implement chrome.extension.isAllowedIncognitoAccess → Implement browser.extension.isAllowedIncognitoAccess
Whiteboard: [extension][good first bug][berlin]
Updated•8 years ago
|
Keywords: dev-doc-needed
Comment 2•8 years ago
|
||
Hello, I would like to work on this bug. Can you please give me some hint since this is my first bug?
Flags: needinfo?(kmaglione+bmo)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → cgrebs
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/39711/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/39711/
Attachment #8730152 -
Flags: review?(kmaglione+bmo)
Assignee | ||
Comment 4•8 years ago
|
||
Need to update https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/Extension/isAllowedIncognitoAccess once review is done.
Comment 5•8 years ago
|
||
Comment on attachment 8730152 [details] MozReview Request: Bug 1253645 - Implement browser.extension.isAllowedIncognitoAccess, r?kmag https://reviewboard.mozilla.org/r/39711/#review36337 ::: toolkit/components/extensions/test/mochitest/test_ext_extension.html:19 (Diff revision 1) > +"use strict"; > + > +add_task(function* test_is_allowed_incognito_access() { > + function backgroundScript() { > + browser.extension.isAllowedIncognitoAccess().then(isAllowedIncognitoAccess => { > + browser.test.assertTrue(isAllowedIncognitoAccess, `isAllowedIncognitoAccess is true`); Please use `assertEq(true, isAllowedIncognitoAccess, ...)` instead, since we want to test against the exact value `true`, rather than just a value which evaluates as true. ::: toolkit/components/extensions/test/mochitest/test_ext_extension.html:20 (Diff revision 1) > + > +add_task(function* test_is_allowed_incognito_access() { > + function backgroundScript() { > + browser.extension.isAllowedIncognitoAccess().then(isAllowedIncognitoAccess => { > + browser.test.assertTrue(isAllowedIncognitoAccess, `isAllowedIncognitoAccess is true`); > + browser.test.notifyPass("ready"); Please use a more specific name for the result than "pass", like "isAllowedIncognitoAccess"
Attachment #8730152 -
Flags: review?(kmaglione+bmo) → review+
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8730152 [details] MozReview Request: Bug 1253645 - Implement browser.extension.isAllowedIncognitoAccess, r?kmag Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39711/diff/1-2/
Assignee | ||
Updated•8 years ago
|
Whiteboard: [extension][good first bug][berlin] → [extension][good first bug][berlin][checkin-needed]
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Whiteboard: [extension][good first bug][berlin][checkin-needed] → [extension][good first bug][berlin]
Updated•8 years ago
|
Flags: needinfo?(kmaglione+bmo)
Comment 9•8 years ago
|
||
Pushed a follow-up which adds a semicolon at the end of a single statement function so eslint stops complaining: https://hg.mozilla.org/integration/mozilla-inbound/rev/fc205e345b60
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a689a66e9e8e https://hg.mozilla.org/mozilla-central/rev/fc205e345b60
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 11•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/cf51b4c7b52eee273b054a363934adde7ec597f5 Bug 1253645: Follow-up: Fix ESLint errors. r=me
Comment 12•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cf51b4c7b52e
Comment 13•8 years ago
|
||
-> https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/extension/isAllowedIncognitoAccess#Browser_compatibility
Keywords: dev-doc-needed → dev-doc-complete
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•