1253647 - Add-on updates that need a restart don't tell you that they're add-on updates.

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Add-on Manager, defect, P3)

Description

[Dave Miller [:justdave]]

Attachment: screen shot of restart dialog

I got this all of the sudden. No indication of why or what caused it. I suspect an add-on updated, but it Durant tell me that.

Comment 1

[Dave Miller [:justdave]]

Doesn't* tell me that.

Comment 2

[Dave Miller [:justdave]]

Akari of note, there's no obvious way to abort the restart if it caught me in the middle of something (which I was)

Comment 3

[Dave Miller [:justdave]]

Also*  --- gee it would be nice if the font size in Bugzilla was big enough on my phone to proofread before I submit :)

Comment 4

[:Margaret Leibovic]

Matt, is this something you could look at?

Comment 5

[Matthew Wein [:mattw]]

Sure!

Comment 6

[Andy McKay]

This should never happen for a WebExtension I believe?

https://dxr.mozilla.org/mozilla-central/source/mobile/android/locales/en-US/chrome/browser.properties?q=Restart+to+complete+changes&redirect_type=single#79

Comment 8

[Jan Henning [:JanH]]

Attachment: Bug 1253647 - Part 0 - Clean up imports.

Review commit: https://reviewboard.mozilla.org/r/138128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138128/

Comment 9

[Jan Henning [:JanH]]

Attachment: Bug 1253647 - Part 1 - Don't show page URL title on add-on restart doorhanger.

When a non-restartless add-on is (un)installed or updated, we show a doorhanger prompting the user to restart. Currently, the doorhanger's title is using the default logic for choosing its title, that is using the base domain of the tab the doorhanger is being displayed on.

By chance, when the doorhanger is triggered from about:addons there is no domain to display, so the doorhanger is just displaying the restart notification. If however an add-on is automatically updated while the user is browsing, then the restart prompt will show the domain of the currently open tab in conjunction with the restart message. This can be confusing for the user, as it looks like it was in fact the current page that triggered the restart prompt.

Therefore, we change this behaviour and just show a generic "Add-ons" as title for this case.

Review commit: https://reviewboard.mozilla.org/r/138130/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138130/

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8866532 [details]
Bug 1253647 - Part 0 - Clean up imports.

https://reviewboard.mozilla.org/r/138128/#review141340

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8866533 [details]
Bug 1253647 - Part 1 - Don't show page URL title on add-on restart doorhanger.

https://reviewboard.mozilla.org/r/138130/#review141342

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb490f8fb183
Part 0 - Clean up imports. r=sebastian
https://hg.mozilla.org/integration/autoland/rev/87279d4bb1d2
Part 1 - Don't show page URL title on add-on restart doorhanger. r=sebastian

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb490f8fb183
https://hg.mozilla.org/mozilla-central/rev/87279d4bb1d2

Comment 14

[Jan Henning [:JanH]]

Attachment: BUG 1253647 - Part 0 - BETA.patch

(fixed imports for patch to work on Beta)

Approval Request Comment
see Part 1

Comment 15

[Jan Henning [:JanH]]

Attachment: BUG 1253647 - Part 1 - BETA.patch

Approval Request Comment
[Feature/Bug causing the regression]: Add-on install restart doorhanger
[User impact if declined]: If a non-restartless add-on updates in background while the user is browsing some page, the doorhanger that prompts the user to restart will display the domain of the currently open tab, making it look like it was the current page that triggered the restart prompt.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: Part 0 of this bug.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Small change to add a new doorhanger type that uses a fixed title instead of the current tab's domain.
[String changes made/needed]: none

Comment 16

[Gerry Chang [:gchang]]

Hi Mihai,
Could you try to verify if the issue is fixed in the latest nightly?

Comment 17

[u549602]

Hi Gerry,

Verified as fixed on the latest Nightly build (55.0a1 / 2017-05-14). This issue was tested on a Samsung Galaxy S6 EDGE (Android 6.0).

Comment 18

[Gerry Chang [:gchang]]

Comment on attachment 8867407 [details] [diff] [review]
BUG 1253647 - Part 0 - BETA.patch

Fix an add-on update prompt issue and was verified. Beta54+. Should be in 54 beta 10 for mobile.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/17d7ab1f17bc
https://hg.mozilla.org/releases/mozilla-beta/rev/bf419245ae3b

Comment 20

[Sorina Florean [:sflorean]]

Tested with Asus ZenPad 8(Android 6.0.1) and Huawei Honor (Android 5.1.1) and the issue is fixed on 54 Beta 10. Mark the flag verified.

Comment 21

[Stefan Deiac]

Based on comment 20 I will remove qe-verify flag.