Closed
Bug 1253671
Opened 8 years ago
Closed 8 years ago
Lint listener and make it strict
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: ato, Assigned: ato)
Details
(Keywords: pi-marionette-server)
Attachments
(1 file)
testing/marionette/listener.js currently has quite a lot of issues that prevents us from including "use strict".
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/38271/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38271/
Attachment #8726847 -
Flags: review?(dburns)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8726847 [details] MozReview Request: Bug 1253671 - Lint listener and make it strict; r?automatedtester https://reviewboard.mozilla.org/r/38271/#review34769
Attachment #8726847 -
Flags: review?(dburns) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8726847 [details] MozReview Request: Bug 1253671 - Lint listener and make it strict; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38271/diff/1-2/
|
|
Assignee | |
Comment 4•8 years ago
|
||
Comment on attachment 8726847 [details] MozReview Request: Bug 1253671 - Lint listener and make it strict; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38271/diff/2-3/
|
|
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 8726847 [details] MozReview Request: Bug 1253671 - Lint listener and make it strict; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38271/diff/3-4/
|
|
Assignee | |
Comment 6•8 years ago
|
||
Unable to reproduce failing and crashing tests in try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1153a68e6b7b Pushing a rebase and triggering new try run.
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8726847 [details] MozReview Request: Bug 1253671 - Lint listener and make it strict; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38271/diff/4-5/
|
|
Assignee | |
Comment 8•8 years ago
|
||
Already fixed by another patch.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•