Closed
Bug 1253693
Opened 5 years ago
Closed 5 years ago
Switch prefer-es6-class React .eslintrc to prefer createClass
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox47 fixed)
RESOLVED
FIXED
Firefox 47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: linclark, Assigned: linclark)
Details
Attachments
(1 file)
793 bytes,
patch
|
jlong
:
review+
|
Details | Diff | Splinter Review |
It turns out that ES6 classes aren't really ready for primetime yet. Apparently there are still perf issues (Bug 1167472). Because of this, we should use the createClass style.
Assignee | ||
Comment 1•5 years ago
|
||
This enforces using createClass all the time. We will switch this once ES6 classes are more production ready.
You can tests this from the command line. Make sure you've updated the react eslint plugin first.
> eslint --no-ignore devtools/client/memory/app.js
Without the patch, you'll see 2 warnings. With it, you'll see 1.
Comment 2•5 years ago
|
||
Comment on attachment 8726893 [details] [diff] [review] Bug1253693-prefer-es6-class-never.patch Review of attachment 8726893 [details] [diff] [review]: ----------------------------------------------------------------- Sounds good, thanks!
Attachment #8726893 -
Flags: review?(jlong) → review+
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fdcd2bcdfdcc
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Updated•3 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•