Closed Bug 1253693 Opened 5 years ago Closed 5 years ago

Switch prefer-es6-class React .eslintrc to prefer createClass

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox47 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: linclark, Assigned: linclark)

Details

Attachments

(1 file)

Bug1253693-prefer-es6-class-never.patch
793 bytes, patch
jlong
: review+
Details | Diff | Splinter Review 
It turns out that ES6 classes aren't really ready for primetime yet. Apparently there are still perf issues (Bug 1167472).

Because of this, we should use the createClass style.
This enforces using createClass all the time. We will switch this once ES6 classes are more production ready.

You can tests this from the command line. Make sure you've updated the react eslint plugin first.

> eslint --no-ignore devtools/client/memory/app.js

Without the patch, you'll see 2 warnings. With it, you'll see 1.
Assignee: nobody → lclark
Status: NEW → ASSIGNED
Attachment #8726893 - Flags: review?(jlong)
Comment on attachment 8726893 [details] [diff] [review]
Bug1253693-prefer-es6-class-never.patch

Review of attachment 8726893 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good, thanks!
Attachment #8726893 - Flags: review?(jlong) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fdcd2bcdfdcc
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.