1253703 - crash in java.lang.IllegalArgumentException: e cannot be null. at org.mozilla.gecko.GeckoAppShell.sendEventToGecko(GeckoAppShell.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is 
report bp-322e6f83-876f-447d-afe0-ed52c2160226.
=============================================================

GeckoEvent.createNativeGestureEvent can fail and return null.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Null-check createNativeGestureEvent result (v1)

createNativeGestureEvent can fail and return null, so we should guard
against that.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8726889 [details] [diff] [review]
Null-check createNativeGestureEvent result (v1)

Review of attachment 8726889 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Uplift if it is safe to.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5624c53dd9a5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5624c53dd9a5

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Uplift?

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Thanks for the reminder!

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8726889 [details] [diff] [review]
Null-check createNativeGestureEvent result (v1)

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Rare crash when panning/zooming
[Describe test coverage new/current, TreeHerder]: No test; patch is a simple fix for a rare crash
[Risks and why]: Very small; patch simply avoids the crash and does not touch anything else
[String/UUID change made/needed]: None

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8726889 [details] [diff] [review]
Null-check createNativeGestureEvent result (v1)

Fix a crash, taking it.
Should be in 46 beta 6

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3099bd33de81

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Only a few crashes on aurora/beta 46 here, but let's take it there too

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8726889 [details] [diff] [review]
Null-check createNativeGestureEvent result (v1)

Crash fix, ok for beta 5/6

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/5d9b02d032be