125373 - crlutil crashes upon certain errors from CRL_ImportCRL

Status: RESOLVED FIXED

(NSS :: Tools, defect, P2)

Description

[Julien Pierre]

When calling CRL_ImportCRL, crlutil does the following :

  193       crl = CERT_ImportCRL (certHandle, &crlDER, url, type, NULL);
  194       if (!crl) {
  195           const char *errString;
  196   
  197           errString = SECU_Strerror(PORT_GetError());
  198           if (PORT_Strlen (errString) == 0)
  199               SECU_PrintError
  200                       (progName, "CRL is not import (error: input CRL is
not up to date.)");

In some cases, SECU_Strerror(Port_GetError()) returns NULL . crlutil then
crashes in the PORT_Strlen . The fix is to check for errString first in the if
statement.

Comment 1

[Julien Pierre]

Checking in crlutil.c;
/cvsroot/mozilla/security/nss/cmd/crlutil/crlutil.c,v  <--  crlutil.c
new revision: 1.7; previous revision: 1.6
done