Closed Bug 1253733 Opened 8 years ago Closed 8 years ago

slow painting transitioning between pages on Workday

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1250037

People

(Reporter: mconley, Assigned: mchang)

References

Details

(Keywords: perf, Whiteboard: [gfx-noted]) 

STR:

1) Log into Workday
2) In the Home page, click on one of the options, like "Performance"

ER:

A big animation should transition us smoothly to the next page.

AR:

A big animation occurs, but it's pretty janky - it hangs for about a second at one point.

Here's jgruen's machine showing the bug in Dev Edition: https://www.dropbox.com/s/u94ui11aew1bgan/workday-hang.gif?dl=0

I see it as well. Here's a profile from my OS X machine running Nightly 47.0a1 (20160304030206):

https://cleopatra.io/#report=4311cabc74e5dfd6c8b0d9888ffc2f429badbcae
Benoit, anything unexpected in the profile from comment 0?
Flags: needinfo?(bgirard)
Whiteboard: [gfx-noted]
The profile adds up with what we're seeing in the gif. There's a long 1+ second contiguous 'hang' in:
'mozilla::gfx::BoxBlurVertical(unsigned char*, unsigned char*, int, int, int, int, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&)'

That's pretty slow. Perhaps the surface size is getting out of hand or that code needs optimization?

Jeff weren't you looking at the blur code performance earlier this week?
Flags: needinfo?(bgirard) → needinfo?(jmuizelaar)
I think the blame here can go to Mason. We are likely blurring too much.
Flags: needinfo?(jmuizelaar) → needinfo?(mchang)
We're probably not hitting the cache due to some weird coordinates from layout.
Assignee: nobody → mchang
Flags: needinfo?(mchang)
Last time I checked this is because we kept creating a blur with a giant border-radius which prevents us from hitting our blur cache. Chrome does something nice with blurring rounded rects but I haven't had the chance to figure out what they are doing.
Severity: normal → major
Keywords: perf
Summary: Hang transitioning between pages on Workday → slow painting transitioning between pages on Workday
Is this a dupe of bug 1250037 then? Also, any updates on this issue in general? It's a pretty ugly jank :(
Flags: needinfo?(mchang)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)
> Is this a dupe of bug 1250037 then? Also, any updates on this issue in
> general? It's a pretty ugly jank :(

Yes, this is a dupe of bug 1250037. No real updates :(, I haven't had time to fix this yet and probably won't for a while :(.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(mchang)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.