1253734 - Add some more editor things to CC traversal

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: editortraverse.patch

I'm not sure we need to traverse nsRangeUpdater. I think it might be always empty by the time we traverse, because we always we add and then remove things to it when executing editor transactions, but I can't tell for sure.

Comment 1

[Peter Van der Beken [:peterv]]

Comment on attachment 8726926 [details] [diff] [review]
editortraverse.patch

Review of attachment 8726926 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, I'm going to switch this to ImplCycleCollectionTraverse/ImplCycleCollectionUnlink.

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 8726940 [details] [diff] [review]
v1

Review of attachment 8726940 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/PlaceholderTxn.cpp
@@ +37,5 @@
>  NS_IMPL_CYCLE_COLLECTION_UNLINK_END
>  
>  NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN_INHERITED(PlaceholderTxn,
>                                                    EditAggregateTxn)
> +  ImplCycleCollectionTraverse(cb, *tmp->mStartSel, "mStartSel", 0);

I guess we haven't needed an overload for nsAutoPtr<> before.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43e80ed311ae

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/43e80ed311ae