graphite2: stack-overflow in [@graphite2::Slot::finalise] Slot.cpp:136

RESOLVED FIXED

Status

()

--
critical
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: tsmith, Unassigned)

Tracking

(Blocks: 1 bug, 4 keywords)

unspecified
crash, csectype-dos, sec-low, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 disabled, firefox46 fixed, firefox47 fixed, firefox48 fixed, firefox-esr3846+ disabled, firefox-esr4546+ disabled)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

1.64 KB, application/x-font-ttf
Details
(Reporter)

Description

3 years ago
Created attachment 8727019 [details]
test_case.ttf

Found in graphite2 revision 520d76818052772d614e581dacea69499b912be6

==51857==ERROR: AddressSanitizer: stack-overflow on address 0x7fff475c1e48 (pc 0x0000004a2317 bp 0x7fff475c26c0 sp 0x7fff475c1e50 T0)
    #0 0x4a2316 in __asan_memcpy /home/user/Desktop/llvm/projects/compiler-rt/lib/asan/asan_interceptors.cc:421
    #1 0x7fd49302c3ff in graphite2::Slot::finalise(graphite2::Segment const*, graphite2::Font const*, graphite2::Position&, graphite2::Rect&, unsigned char, float&, bool, bool) /home/user/code/graphite/src/Slot.cpp:113:16
    #2 0x7fd49302f87e in graphite2::Slot::finalise(graphite2::Segment const*, graphite2::Font const*, graphite2::Position&, graphite2::Rect&, unsigned char, float&, bool, bool) /home/user/code/graphite/src/Slot.cpp:136:25
    ...
    #251 0x7fd49302f87e in graphite2::Slot::finalise(graphite2::Segment const*, graphite2::Font const*, graphite2::Position&, graphite2::Rect&, unsigned char, float&, bool, bool) /home/user/code/graphite/src/Slot.cpp:136:25
(Reporter)

Comment 1

3 years ago
To reproduce:
./gr2fonttest test_case.ttf -auto -demand

Comment 2

3 years ago
Fixed? in 0531c66a35329985e31483236e2ea17a3068697d
(Reporter)

Comment 3

3 years ago
Verified with graphite revision 4dc0e5bab12f0da9c9857dfec0612e57802af808
Whiteboard: [gfx-noted]
(Reporter)

Updated

3 years ago
Depends on: 1255158
(Reporter)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Group: gfx-core-security → core-security-release
Graphite2 has been updated on all affected branches including ESRs.
status-firefox45: --- → wontfix
status-firefox46: --- → fixed
status-firefox47: --- → fixed
status-firefox48: --- → fixed
status-firefox-esr38: --- → fixed
status-firefox-esr45: --- → fixed
tracking-firefox-esr38: --- → 46+
tracking-firefox-esr45: --- → 46+
status-firefox45: wontfix → disabled
status-firefox-esr38: fixed → disabled
status-firefox-esr45: fixed → disabled
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.