1253791 - graphite2: stack-overflow in [@graphite2::Slot::finalise] Slot.cpp:136

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Tyson Smith [:tsmith]]

Attachment: test_case.ttf

Found in graphite2 revision 520d76818052772d614e581dacea69499b912be6

==51857==ERROR: AddressSanitizer: stack-overflow on address 0x7fff475c1e48 (pc 0x0000004a2317 bp 0x7fff475c26c0 sp 0x7fff475c1e50 T0)
    #0 0x4a2316 in __asan_memcpy /home/user/Desktop/llvm/projects/compiler-rt/lib/asan/asan_interceptors.cc:421
    #1 0x7fd49302c3ff in graphite2::Slot::finalise(graphite2::Segment const*, graphite2::Font const*, graphite2::Position&, graphite2::Rect&, unsigned char, float&, bool, bool) /home/user/code/graphite/src/Slot.cpp:113:16
    #2 0x7fd49302f87e in graphite2::Slot::finalise(graphite2::Segment const*, graphite2::Font const*, graphite2::Position&, graphite2::Rect&, unsigned char, float&, bool, bool) /home/user/code/graphite/src/Slot.cpp:136:25
    ...
    #251 0x7fd49302f87e in graphite2::Slot::finalise(graphite2::Segment const*, graphite2::Font const*, graphite2::Position&, graphite2::Rect&, unsigned char, float&, bool, bool) /home/user/code/graphite/src/Slot.cpp:136:25

Comment 1

[Tyson Smith [:tsmith]]

To reproduce:
./gr2fonttest test_case.ttf -auto -demand

Comment 2

[martin_hosken]

Fixed? in 0531c66a35329985e31483236e2ea17a3068697d

Comment 3

[Tyson Smith [:tsmith]]

Verified with graphite revision 4dc0e5bab12f0da9c9857dfec0612e57802af808

Comment 4

[Daniel Veditz [:dveditz]]

Graphite2 has been updated on all affected branches including ESRs.