1253806 - [DevTools][Memory] label.label-by > span element does not have margin-inline-end

Status: RESOLVED FIXED

(DevTools :: Memory, defect, P2)

Description

[magicp]

Attachment: label-by-span-margin-inline-end.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160304030206

Steps to reproduce:

1. Start Nightly (or Aurora)
2. Open DevTools > Memory
3. Switch view from "Aggregate" to "Dominators"


Actual results:

label.label-by > span element does not have margin-inline-end


Expected results:

label.label-by > span element has margin-inline-end: 5px;

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Thanks once again for the bug report, :magicp! :)

To whoever would like to take this bug:

This CSS rule should also match a variant of this selector with ".label-by" instead of ".display-by": https://dxr.mozilla.org/mozilla-central/rev/b6acf4d4fc20431a8ae14bf32cdc6e43a9c0f9ad/devtools/client/themes/memory.css#90

Comment 2

[Umesh Kumhar]

Sir i want to contribute to this bug. I am new contributor to mozilla. please guide me.

email:[e-mail]


thank you

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Umesh, you can follow the instructions here[0] to get a local build of firefox setup. The changes required are described in comment 1, if you have questions, feel free to ask.

I will assign the bug to you once you have attached a patch. Thanks!

[0] https://wiki.mozilla.org/DevTools/Hacking#First_Build

Comment 4

[Umesh Kumhar]

Sir, I just want to clear that what a patch basically contains and how and where i has to attached it. 

thank you

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

You attach it to this bug. See also https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 6

[simplyblue24]

Attachment: 1253806.patch

Hi, Can you please review the patch :D

Comment 7

[Umesh Kumhar]

hey

As simplyblue24 has added patch to bug. Can i still now work on bug. As a starter contributor it is good bug to work on. Am i still eligible to work on or not??

thank you

Comment 8

[simplyblue24]

Hey umesh, you can still work on the bug, I'll unassign myself :)

Comment 9

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8729367 [details] [diff] [review]
1253806.patch

Review of attachment 8729367 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e234f8594e3e

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e234f8594e3e

Comment 12

[Umesh Kumhar]

hey [e-mail]

As you can see that simplyblue24 has unassigned himself from this bug for me to work on. And now i has solved the bug but since the patch file is same what should i do? should i submit same patch file??

thank you

Comment 13

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

You should find a new bug, since we landed simplyblue24's patch.

You can try using bugs ahoy to find a bug that's a good fit for you: http://www.joshmatthews.net/bugsahoy/