Closed Bug 1253822 Opened 8 years ago Closed 8 years ago

Intermittent browser_rules_authored_color.js | This test exceeded the timeout threshold. It should be rewritten or split up.

Categories

(DevTools :: Inspector: Rules, defect, P2)

Product:
DevTools
Component:
Inspector: Rules
Type:
defect

Tracking

(firefox50 unaffected, firefox51 unaffected, firefox52 fixed, firefox53 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 53
Tracking Flags:
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: philor, Assigned: jdescottes)

Details

(Keywords: intermittent-failure, Whiteboard: [btpp-backlog])

Attachments

(1 file)

Bug 1253822 - Rewrite browser_rules_authored_color.js to avoid timeouts;
58 bytes, text/x-review-board-request
gl
: review+
Details 
Filter on CLIMBING SHOES
Priority: -- → P3
Whiteboard: [btpp-backlog]
Increased frequency lately, taking a look.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P3 → P2
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=76f159e59c4ed6fbaa1cdc3264eaf2471d42a642

There are quite a few other timeout intermittents. I don't think they are related as I only modified an existing test.

The updated test took 21 seconds on Linux debug, 11 seconds on Linux 64 debug and 17 seconds on Windows 7 WM, which were the slowest platforms for this test before.
Comment on attachment 8810331 [details]
Bug 1253822 - Rewrite browser_rules_authored_color.js to avoid timeouts;

https://reviewboard.mozilla.org/r/92710/#review93748

Sorry for the delay. The changes look good.

::: devtools/client/inspector/rules/test/browser_rules_authored_color.js:7
(Diff revision 2)
>  /* Any copyright is dedicated to the Public Domain.
>   http://creativecommons.org/publicdomain/zero/1.0/ */
>  
>  "use strict";
>  
>  // Test for as-authored styles.

s/as-authored styles/as-authored color styles/

::: devtools/client/inspector/rules/test/browser_rules_authored_color.js:10
(Diff revision 2)
>  "use strict";
>  
>  // Test for as-authored styles.
>  
> -function* createTestContent(style) {
> -  let html = `<style type="text/css">
> +/**
> + * Array of test colors:

s/test colors/test color objects/
Attachment #8810331 - Flags: review?(gl) → review+
Thanks for the review Gabriel! Applied the comments.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce21333d6f8f
Rewrite browser_rules_authored_color.js to avoid timeouts;r=gl
https://hg.mozilla.org/mozilla-central/rev/ce21333d6f8f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: