Closed
Bug 1253831
Opened 8 years ago
Closed 8 years ago
Intermittent test_retry_ws.js | test_ws_retry - [test_ws_retry : 67] Should wait at least 10000ms before attempt 10 - false == true
Categories
(Core :: DOM: Notifications, defect)
Core
DOM: Notifications
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: philor, Unassigned)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
4.93 KB,
patch
|
wchen
:
review+
|
Details | Diff | Splinter Review |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 6•8 years ago
|
||
Probably the most-frequent Push-related intermittent failure left now.
Flags: needinfo?(wchen)
Comment 7•8 years ago
|
||
Hmm. We probably don't need to be this pedantic about the backoff intervals: https://dxr.mozilla.org/mozilla-central/rev/b3006e4e09af81825badbad69fa3e8c546c7507c/dom/push/test/xpcshell/test_retry_ws.js#66-69 Should we just check that the timeout we set (not when the timer actually fired) is within bounds?
Comment 8•8 years ago
|
||
Does this seem sensible, William?
Flags: needinfo?(wchen)
Attachment #8732560 -
Flags: review?(wchen)
Comment hidden (Intermittent Failures Robot) |
Comment 10•8 years ago
|
||
Comment on attachment 8732560 [details] [diff] [review] backoff.patch Review of attachment 8732560 [details] [diff] [review]: ----------------------------------------------------------------- Yes, this seems reasonable. We can also go a step further and mock out the timer at the component level (see [1] for example) to further isolate the test from the clock. As a side effect, the tests would run faster since we wouldn't have to wait on the timer. [1] https://dxr.mozilla.org/mozilla-central/rev/4037eb98974db1b1e0b5012c8a7f3a36428eaa11/toolkit/components/places/tests/expiration/test_pref_interval.js#51
Attachment #8732560 -
Flags: review?(wchen) → review+
Comment hidden (Intermittent Failures Robot) |
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/69b9c67c96ec
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 14•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/7c164deed223
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•