1253836 - Update references to legacy nsIDOMWindow in mintrayr

Status: RESOLVED FIXED

(Instantbird Graveyard :: Other, defect)

Description

[Abdelrahman Ahmed [:abdelrahman]]

According to bugs (bug 558192 comment 6, bug 1241764 and bug 1250746), we need to replace the legacy interface nsIDOMWindow with mozIDOMWindow and mozIDOMWindowProxy.

At least, We need to fix build failure [1]

[1] https://dxr.mozilla.org/comm-central/source/im/components/mintrayr/trayToolkit.cpp#252

Comment 1

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: patch

Comment 2

[aleth [:aleth]]

Comment on attachment 8728116 [details] [diff] [review]
patch

Review of attachment 8728116 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a little surprised these are all inner windows, but I assume you've tested it and it works. (I can't test it.)

Thanks for fixing this build failure!

Comment 3

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/84b2038479338192e65979c8773af490035162ca
Bug 1253836 - Update references to legacy nsIDOMWindow in mintrayr. r=aleth

Comment 4

[aleth [:aleth]]

Would be good to verify this works on Windows too?

Comment 5

[Patrick Cloke [:clokep]]

Attachment: Port the changes from trayPlatformGtk2 to trayPlatformWin

Build fails on Windows. I've attached a patch. Whoever gets to this first...

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8728212 [details] [diff] [review]
Port the changes from trayPlatformGtk2 to trayPlatformWin

Review of attachment 8728212 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't test the patch, but it seems to do s/nsIDOMWindow/mozIDOMWindow/g to the right files, so r+ from me.

Comment 7

[Patrick Cloke [:clokep]]

Fixed for Windows. Thanks! https://hg.mozilla.org/comm-central/rev/6d0244da634c