Closed Bug 1253836 Opened 4 years ago Closed 4 years ago

Update references to legacy nsIDOMWindow in mintrayr

Categories

(Instantbird :: Other, defect, critical)

defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED
Instantbird 48

People

(Reporter: abdelrahman, Assigned: abdelrahman)

Details

Attachments

(2 files)

According to bugs (bug 558192 comment 6, bug 1241764 and bug 1250746), we need to replace the legacy interface nsIDOMWindow with mozIDOMWindow and mozIDOMWindowProxy.

At least, We need to fix build failure [1]

[1] https://dxr.mozilla.org/comm-central/source/im/components/mintrayr/trayToolkit.cpp#252
Attached patch patchSplinter Review
Attachment #8728116 - Flags: review?(aleth)
Comment on attachment 8728116 [details] [diff] [review]
patch

Review of attachment 8728116 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a little surprised these are all inner windows, but I assume you've tested it and it works. (I can't test it.)

Thanks for fixing this build failure!
Attachment #8728116 - Flags: review?(aleth) → review+
https://hg.mozilla.org/comm-central/rev/84b2038479338192e65979c8773af490035162ca
Bug 1253836 - Update references to legacy nsIDOMWindow in mintrayr. r=aleth
Would be good to verify this works on Windows too?
Severity: normal → critical
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: needinfo?(clokep)
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 48
Build fails on Windows. I've attached a patch. Whoever gets to this first...
Flags: needinfo?(clokep)
Attachment #8728212 - Flags: review?(nhnt11)
Attachment #8728212 - Flags: review?(aleth)
Attachment #8728212 - Flags: review?(ab)
Comment on attachment 8728212 [details] [diff] [review]
Port the changes from trayPlatformGtk2 to trayPlatformWin

Review of attachment 8728212 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't test the patch, but it seems to do s/nsIDOMWindow/mozIDOMWindow/g to the right files, so r+ from me.
Attachment #8728212 - Flags: review?(nhnt11) → review+
Attachment #8728212 - Flags: review?(aleth)
Attachment #8728212 - Flags: review?(ab)
You need to log in before you can comment on or make changes to this bug.