Closed Bug 1253850 Opened 4 years ago Closed 4 years ago

Change MOZ_DEBUG_CHILD_PROCESS back to JIT and add MOZ_DEBUG_CHILD_PAUSE for a 10 second pause.

Categories

(Core :: General, defect, minor)

All
Windows
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: bobowen, Assigned: bobowen)

References

Details

Attachments

(1 file)

Looks like JIT debugging of the child process works well for some people, so re-instate that and use MOZ_DEBUG_CHILD_PAUSE for the 10 second pause.
Put you both to review in case one of you has time this weekend, then I might get in before the merge.
Added the MOZ_DEBUG_CHILD_PAUSE to the posix behaviour as well as it makes sense if some people get used to using that one on Windows.

I'll update the wiki page once this lands.
Attachment #8727095 - Flags: review?(mchang)
Attachment #8727095 - Flags: review?(dvander)
Comment on attachment 8727095 [details] [diff] [review]
On Windows change MOZ_DEBUG_CHILD_PROCESS back to JIT and add MOZ_DEBUG_CHILD_PAUSE for a 10 second pause

Review of attachment 8727095 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!
Attachment #8727095 - Flags: review?(mchang) → review+
Comment on attachment 8727095 [details] [diff] [review]
On Windows change MOZ_DEBUG_CHILD_PROCESS back to JIT and add MOZ_DEBUG_CHILD_PAUSE for a 10 second pause

Thanks Mason, I'll get this landed.
Attachment #8727095 - Flags: review?(dvander)
https://hg.mozilla.org/mozilla-central/rev/41d7e0f6b503
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment on attachment 8727095 [details] [diff] [review]
On Windows change MOZ_DEBUG_CHILD_PROCESS back to JIT and add MOZ_DEBUG_CHILD_PAUSE for a 10 second pause

Approval Request Comment
[Feature/regressing bug #]:
I changed this originally in bug 1252889 just before the uplift.

[User impact if declined]:
Developers who were using this won't have the JIT debugging feature for the child process in Fx47. 

[Describe test coverage new/current, TreeHerder]:
n/a - this is just a debugging feature that doesn't affect testing.

[Risks and why]: 
Low - small change, which only has an effect when the environment variables are set for debugging.

[String/UUID change made/needed]:
None
Attachment #8727095 - Flags: approval-mozilla-aurora?
Comment on attachment 8727095 [details] [diff] [review]
On Windows change MOZ_DEBUG_CHILD_PROCESS back to JIT and add MOZ_DEBUG_CHILD_PAUSE for a 10 second pause

This improves debugging capabilities, taking it.
Attachment #8727095 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.