L10N repacks should use martools from en-US build, not from latest dir

RESOLVED FIXED

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

unspecified
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

3 years ago
See https://bugzilla.mozilla.org/show_bug.cgi?id=1253749#c6 for the details.

L10N builds currently use mar tools from *aurora*'s latest directory, because we don't have nightly builds on the beta/release/esr branches.

At the same time every CI build in release promotion generates martools.

We should teach desktop_l10n.py how to use en-US generated martools - we already pass EN_US_BINARY_URL to the script.
Assignee

Updated

3 years ago
Assignee: nobody → rail
Assignee

Comment 1

3 years ago
Posted file releasetasks patch
Attachment #8728741 - Flags: review?(jlund)
Comment on attachment 8728742 [details]
MozReview Request: Bug 1253871 - L10N repacks should use martools from en-US build, not from latest dir r=jlund a=release

https://reviewboard.mozilla.org/r/39081/#review35747

::: testing/mozharness/scripts/desktop_l10n.py:266
(Diff revision 1)
> +        for prop in ['mar_tools_url']:

this looks weird. is this because you don't want to overwrite other properties?
Comment on attachment 8728742 [details]
MozReview Request: Bug 1253871 - L10N repacks should use martools from en-US build, not from latest dir r=jlund a=release

https://reviewboard.mozilla.org/r/39081/#review35749
Attachment #8728742 - Flags: review+
Assignee

Comment 5

3 years ago
Comment on attachment 8728742 [details]
MozReview Request: Bug 1253871 - L10N repacks should use martools from en-US build, not from latest dir r=jlund a=release

https://hg.mozilla.org/releases/mozilla-beta/rev/8867739057e6

Need to graft to other branches too
Attachment #8728742 - Flags: checked-in+
Assignee

Comment 8

3 years ago
Comment on attachment 8728741 [details] [review]
releasetasks patch

r+ed in the PR
Attachment #8728741 - Flags: review?(jlund)
Attachment #8728741 - Flags: review+
Attachment #8728741 - Flags: checked-in+

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/504e0b786d38
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.