Closed Bug 1253871 Opened 5 years ago Closed 5 years ago

L10N repacks should use martools from en-US build, not from latest dir

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
Tracking Status
firefox48 --- fixed

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(2 files)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1253749#c6 for the details.

L10N builds currently use mar tools from *aurora*'s latest directory, because we don't have nightly builds on the beta/release/esr branches.

At the same time every CI build in release promotion generates martools.

We should teach desktop_l10n.py how to use en-US generated martools - we already pass EN_US_BINARY_URL to the script.
Assignee: nobody → rail
Attached file releasetasks patch
Attachment #8728741 - Flags: review?(jlund)
Attachment #8728742 - Flags: review?(jlund)
Comment on attachment 8728742 [details]
MozReview Request: Bug 1253871 - L10N repacks should use martools from en-US build, not from latest dir r=jlund a=release

https://reviewboard.mozilla.org/r/39081/#review35747

::: testing/mozharness/scripts/desktop_l10n.py:266
(Diff revision 1)
> +        for prop in ['mar_tools_url']:

this looks weird. is this because you don't want to overwrite other properties?
Comment on attachment 8728742 [details]
MozReview Request: Bug 1253871 - L10N repacks should use martools from en-US build, not from latest dir r=jlund a=release

https://reviewboard.mozilla.org/r/39081/#review35749
Attachment #8728742 - Flags: review+
Comment on attachment 8728742 [details]
MozReview Request: Bug 1253871 - L10N repacks should use martools from en-US build, not from latest dir r=jlund a=release

https://hg.mozilla.org/releases/mozilla-beta/rev/8867739057e6

Need to graft to other branches too
Attachment #8728742 - Flags: checked-in+
Comment on attachment 8728741 [details] [review]
releasetasks patch

r+ed in the PR
Attachment #8728741 - Flags: review?(jlund)
Attachment #8728741 - Flags: review+
Attachment #8728741 - Flags: checked-in+
https://hg.mozilla.org/mozilla-central/rev/504e0b786d38
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.