Closed
Bug 1253881
Opened 8 years ago
Closed 8 years ago
[DevTools][Memory] Cannot delete diff heap-view using delete snapshot (clear) button
Categories
(DevTools :: Memory, defect, P2)
DevTools
Memory
Tracking
(firefox46 affected, firefox47 affected, firefox48 fixed)
RESOLVED
FIXED
Firefox 48
People
(Reporter: magicp.jp, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0 Build ID: 20160305030241 Steps to reproduce: 1. Start Nightly (or Aurora) 2. Open DevTools > Memory 3. Make a diff snapshot using compare snapshot 4. Click Delete snapshot (clear) button Actual results: Snapshot list is cleared. But diff heap-view is not cleared. Expected results: Heap-view is cleared.
Blocks: memory-frontend
Has STR: --- → yes
status-firefox46:
--- → affected
status-firefox47:
--- → affected
Component: Untriaged → Developer Tools: Memory
OS: Unspecified → All
Hardware: Unspecified → All
Comment 1•8 years ago
|
||
Julian, Greg: would one of you care to fix this one? I think we need a check in the clear snapshot(s) handlers like: if (diffing) { dispatch(toggleDiffing()); }
Flags: needinfo?(jdescottes)
Flags: needinfo?(gtatum)
Assignee | ||
Comment 2•8 years ago
|
||
Sure, taking the bug!
Assignee: nobody → jdescottes
Flags: needinfo?(jdescottes)
Flags: needinfo?(gtatum)
Assignee | ||
Comment 3•8 years ago
|
||
When clearing all snapshots, if currently displaying a diff, dispatch the diffing.toggleDiffing action. Review commit: https://reviewboard.mozilla.org/r/38507/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38507/
Attachment #8727563 -
Flags: review?(nfitzgerald)
Comment 4•8 years ago
|
||
Comment on attachment 8727563 [details] MozReview Request: Bug 1253881 - memory profiler: toggle diffing when clearing snapshots;r=fitzgen https://reviewboard.mozilla.org/r/38507/#review35133 This is good for when we clear all snapshots, but we should also handle when we remove a single snapshot which is also part of the diffing.
Attachment #8727563 -
Flags: review?(nfitzgerald) → review+
Updated•8 years ago
|
Priority: -- → P2
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3e139a8c3a6e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Assignee | ||
Comment 7•8 years ago
|
||
Nick: This bug is currently tracked by release management for uplift to aurora/beta. Even though it's pretty low risk, I don't think the bug is worth uplifting. What do you think?
Flags: needinfo?(nfitzgerald)
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•