Different eyedropper color-value-box style on Nightly

VERIFIED FIXED in Firefox 47

Status

defect
P1
normal
VERIFIED FIXED
3 years ago
11 months ago

People

(Reporter: magicp.jp, Assigned: bgrins)

Tracking

({regression})

Trunk
Firefox 48
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed, firefox48 verified)

Details

(Whiteboard: [btpp-fix-now])

Attachments

(3 attachments)

Reporter

Description

3 years ago
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160305030241

Steps to reproduce:

1. Start Nightly
2. Menubar > Tools > Web Developer > Eyedropper
3. Confirm color preview size and font style


Actual results:

Different eyedropper color-value-box style on Nightly. Please refer to attached image.
- #color-preview is not square. It seems affected by font-size.
- Different font-family and font-size from other Firefox versions 


Expected results:

#color-preview should be square, and use same font-family and font-size.
Reporter

Updated

3 years ago
Component: Untriaged → Developer Tools
OS: Unspecified → Windows 10
Hardware: Unspecified → x86_64
Component: Developer Tools → Developer Tools: Inspector
Reporter

Updated

3 years ago
OS: Windows 10 → All
Hardware: x86_64 → All
This is a regression in FF47.
This isn't breaking a use case or anything, but still flagging as P1 as this is a regression in 47 that we should try and avoid shipping in Aurora this week, and it looks quite bad.
Keywords: regression
Priority: -- → P1
Whiteboard: [btpp-fix-now]
This looks like a regression from bug 1235781.
Removing the no-theme attribute on <window> in devtools\client\eyedropper\eyedropper.xul seems to fix it.

Brian: you reviewed bug 1235781, could you shade some light on the changes and the best fix for this?
Flags: needinfo?(bgrinstead)
Assignee

Comment 3

3 years ago
Oh, this is probably due to Bug 1246733.  If we re-add a reference to common.css inside of the eyedropper.xul file that should fix it.
Blocks: 1246733
Flags: needinfo?(bgrinstead)
Assignee

Updated

3 years ago
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Assignee

Comment 4

3 years ago
Since the frame doesn't allow any theme to load, common.css isn't be loaded automatically

Review commit: https://reviewboard.mozilla.org/r/38529/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38529/
Assignee

Comment 5

3 years ago
Comment on attachment 8727597 [details]
MozReview Request: Bug 1253886 - Re-add reference to common.css from the eyedropper frame;r=pbrosset

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38529/diff/1-2/
Attachment #8727597 - Attachment description: MozReview Request: Bug 1253886 - Re-add reference to common.css from the eyedropper frame;r=pbro → MozReview Request: Bug 1253886 - Re-add reference to common.css from the eyedropper frame;r=pbrosset
Attachment #8727597 - Flags: review?(pbrosset)
Attachment #8727597 - Flags: review?(pbrosset) → review+
Comment on attachment 8727597 [details]
MozReview Request: Bug 1253886 - Re-add reference to common.css from the eyedropper frame;r=pbrosset

https://reviewboard.mozilla.org/r/38529/#review35293

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9087f64571ad
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Assignee

Comment 9

3 years ago
Comment on attachment 8727597 [details]
MozReview Request: Bug 1253886 - Re-add reference to common.css from the eyedropper frame;r=pbrosset

Approval Request Comment
[Feature/regressing bug #]: 1246733
[User impact if declined]: The text in the 'eyedropper' UI for devtools won't match the rest of devtools
[Describe test coverage new/current, TreeHerder]: None, CSS only change
[Risks and why]: Very low, including an extra shared stylesheet into an iframe
[String/UUID change made/needed]: none
Attachment #8727597 - Flags: approval-mozilla-aurora?
Comment on attachment 8727597 [details]
MozReview Request: Bug 1253886 - Re-add reference to common.css from the eyedropper frame;r=pbrosset

regressed in 47, taking the fix.
Attachment #8727597 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
magicp, could you please verify this issue is fixed as expected on 03/10 Nightly build or later? Thanks!
Flags: needinfo?(magicp.jp)
Reporter

Comment 12

3 years ago
This issue is verified on 03/10 Nightly build.
Flags: needinfo?(magicp.jp)
(In reply to magicp from comment #12)
> Created attachment 8729284 [details]
> Bug-1253886-verified-48.0a1.png
> 
> This issue is verified on 03/10 Nightly build.

Awesome! Thanks.
Status: RESOLVED → VERIFIED

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.