1253901 - Update gcli script versions to jQuery 2.2.0, Lodash 4.6.1, and Underscore 1.8.3

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P2)

Description

[Chris Peterson [:cpeterson]]

Attachment: update-gcli-script-versions.patch

jQuery 2.1.1 -> 2.2.0
Lodash 2.4.1 -> 4.6.1
Underscore 1.7.0 -> 1.8.3

https://ajax.googleapis.com/ajax/libs/jquery/2.2.0/jquery.min.js
https://cdnjs.cloudflare.com/ajax/libs/lodash.js/4.6.1/lodash.min.js
https://cdnjs.cloudflare.com/ajax/libs/underscore.js/1.8.3/underscore-min.js

Is there any reason to prefer the Google-hosted jQuery? cdnjs has a more recent version (2.2.1) and is updated more frequently.

Is this change worth uplifting to Aurora 47 or even Beta 46?

Comment 1

[Joe Walker [:jwalker]]

Comment on attachment 8727146 [details] [diff] [review]
update-gcli-script-versions.patch

Review of attachment 8727146 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Chris,
LGTM, but forwarding r? to :gl who wrote this in the first place

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8727146 [details] [diff] [review]
update-gcli-script-versions.patch

Review of attachment 8727146 [details] [diff] [review]:
-----------------------------------------------------------------

I think the changes are good. I think we can switch to cdnjs for jquery as well. I don't think there was any particular reason why we didn't use cdnjs at the time, but possibly because I just couldn't find the latest version at the time of writing the initial feature.

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

It might be worthwhile to uplift as well.

Comment 4

[Chris Peterson [:cpeterson]]

Thanks, Gabriel. I'll change the jquery link to (the latest version) on cdnjs and then request uplift to Aurora.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae16b59ad280

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ae16b59ad280

Comment 7

[Chris Peterson [:cpeterson]]

Comment on attachment 8727146 [details] [diff] [review]
update-gcli-script-versions.patch

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Web developers using Dev Tools' "gcli inject" test command will be old versions of some popular JavaScript libraries.
[Describe test coverage new/current, TreeHerder]: These JavaScript libraries are very popular and (presumably :) stable.
[Risks and why]: Low risk because Firefox itself does not depend on these libraries. They are a convenience for web developers.
[String/UUID change made/needed]: N/A

jQuery 2.1.1 -> 2.2.0
Lodash 2.4.1 -> 4.6.1
Underscore 1.7.0 -> 1.8.3

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Tomcat uplifted this.
https://hg.mozilla.org/releases/mozilla-aurora/rev/23310a1c6232