Closed
Bug 1253961
Opened 8 years ago
Closed 8 years ago
Can GC during timed portion of TPS test
Categories
(Testing :: Talos, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: billm, Assigned: billm)
References
Details
Attachments
(1 file)
1.50 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
Here's what happens: - We get multiple notifications that a few pages, like aljazeera and the guardian, have loaded. The first notification is actually an error (not sure why this happens) while the second is real. - We load the frame script into these tabs twice. - When we ask these tabs to GC, they do it twice and send back two acknowledgements. - After the first acknowledgement, we start the timed portion of the test even though the second GC is still happening. This patch ignores the notifications that have non-successful status.
Attachment #8727204 -
Flags: review?(mconley)
Comment 1•8 years ago
|
||
Comment on attachment 8727204 [details] [diff] [review] patch Thank you for figuring that out!
Attachment #8727204 -
Flags: review?(mconley) → review+
Comment 2•8 years ago
|
||
Because of signing requirements, we'll need to repack and sign the tabswitcher addon. Ni'ing myself for instructions.
Flags: needinfo?(mconley)
Comment 3•8 years ago
|
||
So tabswitcher will need to be signed in order to run in automation: https://wiki.mozilla.org/EngineeringProductivity/HowTo/SignExtensions You'll need jpm 1.0.6 to do this. Let me know if you have any questions or hit any roadblocks.
Flags: needinfo?(mconley)
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/ef7006351314c812fe04d08b5ab49c66e49cfcc8 Bug 1253961 - Load talos-content.js framescript only once in tabswitch browsers to avoid GC's during timed portion of Talos test. r=mconley
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ef7006351314
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•