Don't set negative margin-inline-start to dbg-breakpoint of source-item which does not have indent.

VERIFIED FIXED in Firefox 47

Status

defect
VERIFIED FIXED
3 years ago
11 months ago

People

(Reporter: magicp.jp, Assigned: ntim)

Tracking

({regression})

Trunk
Firefox 48
Dependency tree / graph

Firefox Tracking Flags

(firefox46 unaffected, firefox47 verified, firefox48 verified)

Details

Attachments

(3 attachments)

Reporter

Description

3 years ago
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160306030215

Steps to reproduce:

1. Start Nightly
2. Go to about:home
3. Open DevTools > Debugger
4. Select "about:home" from source list
5. Add breakpoint on any line numbers


Actual results:

Added dbg-breakpoint has negative margin-inline-start and its check box is in out of window.


Expected results:

Don't set negative margin-inline-start to dbg-breakpoint of source-item which does not have indent.
Reporter

Updated

3 years ago
Has STR: --- → yes
Component: Untriaged → Developer Tools: Debugger
OS: Unspecified → All
Hardware: Unspecified → All
Assignee

Updated

3 years ago
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Assignee

Updated

3 years ago
Keywords: regression
Assignee

Updated

3 years ago
No longer blocks: dt-theme-cleanup
Comment on attachment 8728546 [details]
MozReview Request: Bug 1253981 - Fix out of view breakpoint checkboxes in debugger. r=bgrins

https://reviewboard.mozilla.org/r/38969/#review35651
Attachment #8728546 - Flags: review?(bgrinstead) → review+
Assignee

Comment 5

3 years ago
Comment on attachment 8728546 [details]
MozReview Request: Bug 1253981 - Fix out of view breakpoint checkboxes in debugger. r=bgrins

Approval Request Comment
[Feature/regressing bug #]: bug 1184644
[User impact if declined]: see attachment 8727225 [details]
[Describe test coverage new/current, TreeHerder]: tested locally, soon in nightly
[Risks and why]: Low, small CSS change
[String/UUID change made/needed]: none
Attachment #8728546 - Flags: approval-mozilla-aurora?

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2c9d4c7e3d2d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
magicp, could you please verify this issue is fixed as expected on a 03-11 Nightly build (should be available in ~12 hours)? Thanks!
Flags: needinfo?(magicp.jp)
Comment on attachment 8728546 [details]
MozReview Request: Bug 1253981 - Fix out of view breakpoint checkboxes in debugger. r=bgrins

CSS only, taking it.
Attachment #8728546 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: qe-verify+
Reporter

Comment 9

3 years ago
(In reply to Ritu Kothari (:ritu) from comment #7)
> magicp, could you please verify this issue is fixed as expected on a 03-11
> Nightly build (should be available in ~12 hours)? Thanks!

Yes, I can.
Reporter

Comment 10

3 years ago
This issue was fixed. Thanks!
Flags: needinfo?(magicp.jp)
(In reply to magicp from comment #10)
> Created attachment 8729517 [details]
> Bug-1253981-verified-48.0a1.png
> 
> This issue was fixed. Thanks!

Great!
Status: RESOLVED → VERIFIED
Reproduced with 47.0a1 (from 2016-03-06) on Windows 7 64-bit.
Verified fixed with 47 beta 8 (Build ID: 20160523113146) and latest Aurora 48.0a2, under Windows 7 64-bit, Mac OS X 10.10.5 and Ubuntu 14.04 32-bit.

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.