Closed Bug 1253994 Opened 4 years ago Closed 4 years ago

Unable to get content process profiles in some cases

Categories

(Core :: DOM: Content Processes, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: billm, Assigned: billm)

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

There's a small window, between when we close all the tabs for a content process and when it actually dies, where we can't get a profile for that process. This patch fixes that problem.

I also noticed that the Talos profiling harness uses a sync method to gather a profile, which means that it won't get profiles for currently running content processes. In my case, the content process is still running even though all tabs have closed (although only for a short time). So the patch changes Talos to use an async method. Writing to the file is kind of awkward, unfortunately. I tried using OS.File.writeAtomic, but it didn't work and I couldn't figure out why.
Attached patch patchSplinter Review
Attachment #8727245 - Flags: review?(mconley)
Comment on attachment 8727245 [details] [diff] [review]
patch

Review of attachment 8727245 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, let's do this.

Unfortunately, you'll need to re-sign and re-pack pageloader-signed.xpi in order for this change to take effect in the tree.
Attachment #8727245 - Flags: review?(mconley) → review+
Whiteboard: btpp-active
https://hg.mozilla.org/mozilla-central/rev/57fd0306e82e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.