1253999 - [DevTools][Memory] Dagre-D3 graph needs more contrast between object and background on the light theme

Status: RESOLVED WORKSFORME

(DevTools :: Memory, defect, P2)

Description

[magicp]

Attachment: devtools-memory-Dagre-D3.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160306030215

Steps to reproduce:

1. Start Nightly
2. Open DevTools > Memory with the light theme
3. Switch view from "Aggregate" to "Dominators"
4. Select any rows from the heap-view


Actual results:

Hard to see between object and background by less contrast.


Expected results:

Dagre-D3 graph needs more contrast between object and background on the light theme.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Helen, is this fallout from your recent light-theme changes? I am used to how it looks on the right, but I haven't rebased on m-c in a week or so.

Comment 2

[Helen V. Holmes (:helenvholmes) (:✨)]

Attachment: dagre-contrast.patch

So, I agree that the contrast is bad on the light theme. Seems like an easy fix; let's just change the fill on those nodes from --theme-toolbar-background to --theme-splitter-color.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8732882 [details] [diff] [review]
dagre-contrast.patch

Review of attachment 8732882 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Helen!