12540 - UMR from CSSParserImpl::ParseDeclarationBlock()

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Bruce Mitchener]

This happens somewhere over a thousand times during startup of 'viewer -url
about:blank'

****  Purify instrumented ./viewer.pure (pid 738)  ****
UMR: Uninitialized memory read (232 times):
  * This is occurring while in:
        CSSParserImpl::AppendValue(nsICSSDeclaration*,nsCSSProperty,const
nsCSSValue&,int&) [nsCSSParser.cpp:2538]
        CSSParserImpl::ParseBorder(int&,nsICSSDeclaration*,int&)
[nsCSSParser.cpp:3317]
        CSSParserImpl::ParseProperty(int&,nsICSSDeclaration*,nsCSSProperty,int&)
[nsCSSParser.cpp:2604]
        CSSParserImpl::ParseDeclaration(int&,nsICSSDeclaration*,int,int&)
[nsCSSParser.cpp:1915]
        CSSParserImpl::ParseDeclarationBlock(int&,int) [nsCSSParser.cpp:1778]
        CSSParserImpl::ParseRuleSet(int&) [nsCSSParser.cpp:1129]
        CSSParserImpl::Parse(nsIUnicharInputStream*,nsIURI*,nsICSSStyleSheet*&)
[nsCSSParser.cpp:446]

CSSLoaderImpl::ParseSheet(nsIUnicharInputStream*,SheetLoadData*,int&,nsICSSStyle
Sheet*&) [nsCSSLoader.cpp:739]

CSSLoaderImpl::LoadAgentSheet(nsIURI*,nsICSSStyleSheet*&,int&,void(*)(nsICSSStyl
eSheet*,void*),void*) [nsCSSLoader.cpp:1313]
        nsLayoutDLF::InitUAStyleSheet() [nsLayoutDLF.cpp:635]
        nsLayoutDLF::CreateDocument(const
char*,nsIChannel*,nsILoadGroup*,nsIContentViewerContainer*,const
nsID&,nsIStreamListener**,nsIContentViewer**) [nsLayoutDLF.cpp:404]
        nsLayoutDLF::CreateInstance(const char*,nsIChannel*,nsILoadGroup*,const
char*,nsIContentViewerContainer*,nsISupports*,nsIStreamListener**,nsIContentView
er**) [nsLayoutDLF.cpp:281]
        nsDocLoaderImpl::CreateContentViewer(const char*,nsIChannel*,const
char*,nsIContentViewerContainer*,nsISupports*,nsIStreamListener**,nsIContentView
er**) [nsDocLoader.cpp:583]
        nsDocumentBindInfo::OnStartRequest(nsIChannel*,nsISupports*)
[nsDocLoader.cpp:1923]
        nsInputStreamChannel::AsyncRead(unsigned
int,int,nsISupports*,nsIStreamListener*) [nsInputStreamChannel.cpp:138]
        nsDocumentBindInfo::Bind(nsIURI*,nsIStreamListener*,nsIInputStream*)
[nsDocLoader.cpp:1691]
        nsDocumentBindInfo::Bind(const
nsString&,nsIInputStream*,nsIStreamListener*) [nsDocLoader.cpp:1618]
        nsDocLoaderImpl::LoadDocument(const nsString&,const
char*,nsIContentViewerContainer*,nsIInputStream*,nsISupports*,nsIStreamObserver*
,unsigned int,unsigned int) [nsDocLoader.cpp:671]
        nsWebShell::DoLoadURL(const nsString&,const
char*,nsIInputStream*,unsigned int,unsigned int) [nsWebShell.cpp:2126]
        nsWebShell::LoadURL(const unsigned short*,const
char*,nsIInputStream*,int,unsigned int,unsigned int) [nsWebShell.cpp:2311]
        nsBrowserWindow::GoTo(const unsigned short*,const char*)
[nsBrowserWindow.cpp:708]
        nsViewerApp::OpenWindow() [nsViewerApp.cpp:631]
        nsNativeViewerApp::Run() [nsGtkMain.cpp:46]
        main           [nsGtkMain.cpp:126]
        _start         [crt1.o]
  * Reading 4 bytes from 0xefffe474 on the stack.
  * Address 0xefffe474 is local variable "hint" in function
CSSParserImpl::ParseDeclarationBlock(int&,int).

Comment 1

[Peter Linss]

This is actually harmless because the value in question is an out param that is
not used in this call path. But, since it's noise for purify, a fix is going in
with my next checkin.

Comment 2

[Peter Linss]

*** Bug 12990 has been marked as a duplicate of this bug. ***

Comment 3

[Christine Hoffman]

[e-mail]: Would you please take a look at this and mark the bug
verified if you agree? I have insufficient information to do so. Thanks

Comment 4

[Christine Hoffman]

No response from reporter. Verifying bug fixed. If reporter does not agree,
please reopen.

Comment 5

[Bruce Mitchener]

I didn't see this the last time that I tried, but I have no time for Mozilla
related things these days.