1254033 - No warning message displayed when trying to sign up for MP newsletter without an e-mail

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Valentina Virlics [:vvalentina], Ecosystem QA]

Steps to reproduce:
1. Load MP-stage page https://marketplace.allizom.org/
2. Go to page footer
3. Click the "Sign me up" button from the Newsletter section
4. Observe the e-mail warning message 

Expected results:
"Please fill out this field" message is displayed.

Actual results:
No warning message displayed.

Notes/Issues:
The issue is not reproducing on FF OS.
Verified on FF47(Win 7). Issue is reproducing on MP-stage, dev and prod.
Screenshot for this issue: http://screencast.com/t/lGkDSw37oBVb

Comment 1

[Valentina Virlics [:vvalentina], Ecosystem QA]

On FF OS 2.1 if there is no e-mail address in the field and the "Sign me up" button is clicked: the field is made smaller. Please see the screenshot: http://screencast.com/t/AHHELnca
The email field returns to its regular size when entering a longer email and clicking "Sign me up" again.

Comment 2

[David Durst [:ddurst]]

Looks  like we're supposed to have a string in that red callout. There's text there, but I guess CSS is scrunching the balloon and (effectively) hiding it?

Comment 3

[Davor Spasovski [:spasovski]]

https://github.com/mozilla/fireplace/commit/9a58a10

Comment 4

[Valentina Virlics [:vvalentina], Ecosystem QA]

The issue from comment #0 is still reproducible on MP-dev FF48(Win 7) - http://screencast.com/t/OnfWbAwj

The issue from comment #1 was verified as fixed on FF OS 2.1(Flame) - http://screencast.com/t/pWNqmRxb4bh

I guess this is actually my bad, because I mentioned two issues in one.
Being in the same section... that was my call.

Comment 5

[Davor Spasovski [:spasovski]]

Good call, this was only happening on desktop but fixed now.

https://github.com/mozilla/fireplace/commit/41b8e0e

Comment 6

[Valentina Virlics [:vvalentina], Ecosystem QA]

Verified as fixed on MP-dev FF48(Win 7).
Postfix screenshot: http://screencast.com/t/GLws0k8ewNt
Closing bug.