1254039 - [TV][Home] Move rename, rearrange, and delete from edit mode to context menu.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

In v2.6, we decide to remove rename, rearrange, and delete features to context menu.

Then we no longer enter edit mode directly.

Comment 1

[Josh Cheng [:josh]]

Hi Fischer,
Could you provide a target milestone?
Thanks

Comment 2

[Fischer [:Fischer]]

Target to have the function implementation done and get into code review this week.
However, some UI styles are not yet ready so the UI styles would be done in another bug once ready.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:bug_1254039-home-context-menu > mozilla-b2g:master

Comment 4

[Fischer [:Fischer]]

Comment on attachment 8742185 [details] [review]
[gaia] Fischer-L:bug_1254039-home-context-menu > mozilla-b2g:master

@Rex,

This patch

- Enable context menu based on app type to edit cards in smart home:
  - deck type: move,
  - folder type: move, edit folder,
  - tv, app, appbookmark: move, rename, remove

- Context menu only can be triggered in the normal state

- Remove the edit button so as to enter edit mode only through context menu

Thanks

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8742185 [details] [review]
[gaia] Fischer-L:bug_1254039-home-context-menu > mozilla-b2g:master

This patch is going on a direction that I didn't expected.

Let's have some discussion tomorrow.

Comment 6

[Fischer [:Fischer]]

Comment on attachment 8742185 [details] [review]
[gaia] Fischer-L:bug_1254039-home-context-menu > mozilla-b2g:master

@Rex,

Update the patch to 
- Move focus handling during enter.exiting the edit mode inside the toggleEditMode method.
- Use event instead of Promise to reduce the complexity of removing card job.

Thanks

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8742185 [details] [review]
[gaia] Fischer-L:bug_1254039-home-context-menu > mozilla-b2g:master

Much better but I think we can make things easier. See my comments on Github.

Comment 8

[Fischer [:Fischer]]

Comment on attachment 8742185 [details] [review]
[gaia] Fischer-L:bug_1254039-home-context-menu > mozilla-b2g:master

@Luke,

This patch has been updated based on Rex's suggestions:
- Skip entering the edit mode and rename/unpin card directly
- Bind contextmenu to folder-list and card-list to eliminate the handling of disable contextmenu when showing card picker.

Please have a look.

Thank you.

Comment 9

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8742185 [details] [review]
[gaia] Fischer-L:bug_1254039-home-context-menu > mozilla-b2g:master

Great work! Thanks.

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:bug_1254039-home-context-menu > mozilla-b2g:v2.6

Comment 11

[Fischer [:Fischer]]

Land to v2.6: https://github.com/mozilla-b2g/gaia/commit/ed6a23e58012b500299c8ae6415063af16b21240