Closed
Bug 1254097
Opened 8 years ago
Closed 8 years ago
Text chat notification when user joins room
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fcampo, Assigned: fcampo)
References
Details
(Whiteboard: [btpp-fix-later][ux-triage])
Attachments
(3 files)
|
1.12 MB,
image/png
|
Details | |
|
40 bytes,
text/x-github-pull-request
|
crafuse
:
review+
|
Details | Review |
|
24.06 KB,
image/png
|
Pau
:
ui-review+
Pau
:
ui-review+
|
Details |
friend left but still writes.png
Besides the system notifications, it would be useful to have a message on the chat for keeping track of the user at the other end connection/disconnection. We have already a message when a friend leaves, but not when joins again, so the text chat history seems weird if a user disconnects, connects again and writes something.
|
Assignee | |
Updated•8 years ago
|
Flags: needinfo?(sfranks)
Flags: needinfo?(b.pmm)
|
||
Comment 1•8 years ago
|
||
Yes, agreed. Can probably just mirror the image and say "Your friend has joined."
Flags: needinfo?(sfranks)
Flags: needinfo?(b.pmm)
|
||
Updated•8 years ago
|
Rank: 29
Priority: -- → P2
|
|
||
Updated•8 years ago
|
Whiteboard: [btpp-fix-later]
|
|
||
Updated•8 years ago
|
Whiteboard: [btpp-fix-later] → [btpp-fix-later][ux-triage]
|
||
Comment 3•8 years ago
|
||
|
|
Assignee | |
Comment 4•8 years ago
|
||
Attachment #8748630 -
Flags: ui-review?(sfranks)
Attachment #8748630 -
Flags: ui-review?(b.pmm)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8748626 -
Flags: review?(dcritchley)
Attachment #8748626 -
Flags: review?(crafuse)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → fernando.campo
Status: NEW → ASSIGNED
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8748630 [details]
patched-UX
It's fine for now. When we get the new visuals for Akita it'll probably change a bit. Thanks Fernando!
Attachment #8748630 -
Flags: ui-review?(sfranks)
Attachment #8748630 -
Flags: ui-review?(b.pmm)
Attachment #8748630 -
Flags: ui-review+
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8748626 [details] [review] [loop] fcampo:joined-peer-message-1254097 > mozilla:master Looks good, Going to run tests.
Attachment #8748626 -
Flags: review?(dcritchley)
|
|
||
Comment 7•8 years ago
|
||
Comment on attachment 8748626 [details] [review] [loop] fcampo:joined-peer-message-1254097 > mozilla:master Once rebased to master should be good to go. r=crafuse.
Attachment #8748626 -
Flags: review?(crafuse) → review+
|
|
Assignee | |
Comment 8•8 years ago
|
||
https://github.com/mozilla/loop/commit/eba93ea2e009f6d61e2792fd7b54940ab8527751
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•