Closed Bug 1254184 Opened 4 years ago Closed 4 years ago

can't tell which address book is selected if focus is not in the list of address books

Categories

(Thunderbird :: Address Book, defect)

Unspecified
Windows 7
defect
Not set

Tracking

(thunderbird45 fixed, thunderbird46 fixed, thunderbird47 fixed, thunderbird48 fixed)

RESOLVED FIXED
Thunderbird 48.0
Tracking Status
thunderbird45 --- fixed
thunderbird46 --- fixed
thunderbird47 --- fixed
thunderbird48 --- fixed

People

(Reporter: wsmwk, Assigned: Paenglab)

Details

Attachments

(2 files)

(this almost drives me crazy, I can't believe I haven't filed this before)

If focus is not in the list of address books, you can't tell which address book is selected.  Everything is just grey
What version are you on? I thought we dropped the colored sidebar.
Attached patch bug1254184.patchSplinter Review
On Win7+ Classic the background color is the same as the inactive treechildren color. Removing the background color and let it white is better.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8727532 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 8727532 [details] [diff] [review]
bug1254184.patch

Review of attachment 8727532 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8727532 - Flags: review?(squibblyflabbetydoo) → review+
Indeed, I'm win7 classic. (screen shot is 38.6.0 in clean profile)
OS: Unspecified → Windows 7
Keywords: checkin-needed
TB 45?
http://hg.mozilla.org/comm-central/rev/e8c12056fba8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
Comment on attachment 8727532 [details] [diff] [review]
bug1254184.patch

(In reply to Kent James (:rkent) from comment #5)
> TB 45?

Yes, please.

[Approval Request Comment]
User impact if declined: invisible unfocused selection on win7+ Classic themes
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8727532 - Flags: approval-comm-esr45?
Attachment #8727532 - Flags: approval-comm-beta?
Attachment #8727532 - Flags: approval-comm-aurora?
You need to log in before you can comment on or make changes to this bug.