Closed Bug 1254263 Opened 5 years ago Closed 5 years ago

Add a pref to stop skipping paints

Categories

(Core :: Panning and Zooming, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox46 --- fixed
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Keywords: feature, Whiteboard: [gfx-noted])

Attachments

(1 file)

We have some code that tries to avoid doing paints on the main thread if APZ is scrolling; it was added in bug 1187432. In general this is good, but if we have bugs where APZ doesn't update things properly then they can be made worse by this paint skipping. We should add a kill switch pref to disable the paint skipping in case we need it.
Assignee: nobody → bugmail.mozilla
Keywords: feature
Whiteboard: [gfx-noted]
Comment on attachment 8727584 [details]
MozReview Request: Bug 1254263 - Add a flag to allow disabling paint-skipping. r?mstange

https://reviewboard.mozilla.org/r/38515/#review35145
Attachment #8727584 - Flags: review?(mstange) → review+
https://hg.mozilla.org/mozilla-central/rev/65f225f7d0db
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment on attachment 8727584 [details]
MozReview Request: Bug 1254263 - Add a flag to allow disabling paint-skipping. r?mstange

Approval Request Comment
[Feature/regressing bug #]: adds a pref to disable APZ paint skipping
[User impact if declined]: none really, but it's good to have a pref to disable this feature just in case
[Describe test coverage new/current, TreeHerder]: tested locally, been on m-c for a few days
[Risks and why]: low risk. just adds a pref to control some behaviour.
[String/UUID change made/needed]: none
Attachment #8727584 - Flags: approval-mozilla-beta?
Attachment #8727584 - Flags: approval-mozilla-aurora?
Comment on attachment 8727584 [details]
MozReview Request: Bug 1254263 - Add a flag to allow disabling paint-skipping. r?mstange

new pref, tested locally, taking it.
Attachment #8727584 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8727584 [details]
MozReview Request: Bug 1254263 - Add a flag to allow disabling paint-skipping. r?mstange

Adds a pref for more control over APZ features, ok to uplift
Attachment #8727584 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I'm hitting conflicts uplifting this to beta:

grafting 332450:5ba3d463ebff "Bug 1254263 - Add a flag to allow disabling paint-skipping. r=mstange a=ritu"
merging gfx/layers/apz/src/AsyncPanZoomController.cpp
merging gfx/thebes/gfxPrefs.h
merging layout/generic/nsGfxScrollFrame.cpp
merging layout/xul/nsSliderFrame.cpp
merging modules/libpref/init/all.js
warning: conflicts while merging gfx/layers/apz/src/AsyncPanZoomController.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging gfx/thebes/gfxPrefs.h! (edit, then use 'hg resolve --mark')
warning: conflicts while merging modules/libpref/init/all.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue


Can we get a rebased patch if this needs uplifting to beta?
Flags: needinfo?(bugmail.mozilla)
You need to log in before you can comment on or make changes to this bug.