browser_UITour_loop_panel.js causes complaints from telemetry when opening the panel

RESOLVED WORKSFORME

Status

Hello (Loop)
Client
P2
normal
Rank:
20
RESOLVED WORKSFORME
2 years ago
2 years ago

People

(Reporter: Gijs, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [btpp-followup-2016-03-16])

(Reporter)

Description

2 years ago
From bug 1254202:

09:29:46     INFO -  199 INFO TEST-START | browser/components/uitour/test/browser_UITour_loop_panel.js
09:29:46     INFO -  console.error: Loop:
09:29:46     INFO -    TelemetryAddValue failed for histogram 'LOOP_MAU'
09:29:46     INFO -    Message: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsITelemetry.getHistogramById]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://loop/content/modules/MozLoopAPI.jsm :: kMessageHandlers.TelemetryAddValue :: line 1068"  data: no]
09:29:46     INFO -    Stack:
09:29:46     INFO -      kMessageHandlers.TelemetryAddValue@chrome://loop/content/modules/MozLoopAPI.jsm:1068:11
09:29:46     INFO -  this.LoopAPI<.sendMessageToHandler@chrome://loop/content/modules/MozLoopAPI.jsm:1388:7
09:29:46     INFO -  WindowListener.setupBrowserUI/LoopUI.openPanel/</callback@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///builds/slave/test/build/application/Nightly.app/Contents/Resources/browser/features/loop@mozilla.org.xpi!/bootstrap.js:190:13
09:29:46     INFO -  PanelFrame.showPopup@resource://app/modules/PanelFrame.jsm:193:7
09:29:46     INFO -  WindowListener.setupBrowserUI/LoopUI.openPanel/</<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///builds/slave/test/build/application/Nightly.app/Contents/Resources/browser/features/loop@mozilla.org.xpi!/bootstrap.js:212:13
09:29:46     INFO -  Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
09:29:46     INFO -  this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
09:29:46     INFO -  Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
09:29:46     INFO -  this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
09:29:46     INFO -  Promise.prototype.then@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:454:5
09:29:46     INFO -  WindowListener.setupBrowserUI/LoopUI.openPanel/<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///builds/slave/test/build/application/Nightly.app/Contents/Resources/browser/features/loop@mozilla.org.xpi!/bootstrap.js:199:11
09:29:46     INFO -  WindowListener.setupBrowserUI/LoopUI.openPanel@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///builds/slave/test/build/application/Nightly.app/Contents/Resources/browser/features/loop@mozilla.org.xpi!/bootstrap.js:178:16
09:29:46     INFO -  this.UITour.showMenu@resource://app/modules/UITour.jsm:1756:7
09:29:46     INFO -  this.UITour.onPageEvent@resource://app/modules/UITour.jsm:568:9
09:29:46     INFO -  @resource://app/components/nsBrowserGlue.js:3220:3
I strongly suspect this is a DUP of bug 1254958, which just landed in git.  Standard8, can you confirm that and resolve this bug if appropriate?
Rank: 15
Flags: needinfo?(standard8)
Priority: -- → P1
Whiteboard: [btpp-followup-2016-03-16]

Comment 2

2 years ago
Decreasing the priority since not critical to fix in this iteration.
Rank: 15 → 20
Priority: P1 → P2
This will be fixed automatically once we roll out 1.2 to mozilla-central - probably tomorrow or early next week. There's nothing special for us to do here.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Flags: needinfo?(standard8)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.