Closed
Bug 1254380
Opened 8 years ago
Closed 8 years ago
Align the exception reporting in ScriptSettings more closely with what we do in nsJSEnvironment
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(3 files)
2.23 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
6.96 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
1.48 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8727692 -
Flags: review?(bobbyholley)
Updated•8 years ago
|
Attachment #8727692 -
Flags: review?(bobbyholley) → review+
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8727697 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8727699 -
Flags: review?(bobbyholley)
Comment 4•8 years ago
|
||
Comment on attachment 8727697 [details] [diff] [review] part 2. Go ahead and log the stack from our exception in AutoJSAPI::ReportException even if we don't have a window Review of attachment 8727697 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/xpconnect/src/xpcpublic.h @@ +515,3 @@ > void LogToConsole(); > + // Log to console, using the given stack object (which should be a stack of > + // the sort that JS::CaptureCurrentStack produces. aStack is allowed to be Nit: Missing close-paren.
Attachment #8727697 -
Flags: review?(bobbyholley) → review+
Updated•8 years ago
|
Attachment #8727699 -
Flags: review?(bobbyholley) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f47cf7a006ba https://hg.mozilla.org/integration/mozilla-inbound/rev/5b142d0aa554 https://hg.mozilla.org/integration/mozilla-inbound/rev/8f212b1ebdd0
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f47cf7a006ba https://hg.mozilla.org/mozilla-central/rev/5b142d0aa554 https://hg.mozilla.org/mozilla-central/rev/8f212b1ebdd0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•