Closed Bug 1254380 Opened 8 years ago Closed 8 years ago

Align the exception reporting in ScriptSettings more closely with what we do in nsJSEnvironment

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(3 files)

      No description provided.
Attachment #8727692 - Flags: review?(bobbyholley) → review+
Blocks: 1254393
Comment on attachment 8727697 [details] [diff] [review]
part 2.  Go ahead and log the stack from our exception in AutoJSAPI::ReportException even if we don't have a window

Review of attachment 8727697 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/xpcpublic.h
@@ +515,3 @@
>      void LogToConsole();
> +    // Log to console, using the given stack object (which should be a stack of
> +    // the sort that JS::CaptureCurrentStack produces.  aStack is allowed to be

Nit: Missing close-paren.
Attachment #8727697 - Flags: review?(bobbyholley) → review+
Attachment #8727699 - Flags: review?(bobbyholley) → review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: