Closed Bug 1254384 Opened 4 years ago Closed 4 years ago

SpiderMonkey jit-tests use cookies when they could just pass flags

Categories

(Core :: JavaScript Engine, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jimb, Assigned: jimb)

Details

Attachments

(2 files)

Many of the tests in js/src/jit-test use test metalines containing the special-purpose flags ion-eager, baseline-eager, and dump-bytecode, when those could perfectly well be specified using the generic metaline --SWITCH syntax.

The tests should be changed to use the generic syntax, and support for the special-purposes flags should be removed from the test harness.
Assignee: nobody → jimb
Status: NEW → ASSIGNED
Attachment #8727696 - Flags: review?(shu)
Comment on attachment 8727698 [details] [diff] [review]
Remove support for ion-eager, baseline-eager, and dump-bytecode from js/src/jit-test harness.

Review of attachment 8727698 [details] [diff] [review]:
-----------------------------------------------------------------

As I added the "--" shortcut, I will take over these reviews.
Attachment #8727698 - Flags: review?(shu) → review+
Attachment #8727696 - Flags: review?(shu) → review+
Flags: in-testsuite-
Target Milestone: --- → mozilla48
https://hg.mozilla.org/mozilla-central/rev/5ebb48a2046b
https://hg.mozilla.org/mozilla-central/rev/8bb37f2f3d45
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.