1254406 - Remove unneeded check on CC_NAME

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Martin Thomson [:mt:]]

Attachment: excessive check removed

This is fairly trivial, but without it, -Werror is disabled on my machine.

Note that we already have a check for CC_IS_GCC above.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8727710 [details] [diff] [review]
excessive check removed

Review of attachment 8727710 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I think that should be fine.

Comment 2

[Martin Thomson [:mt:]]

https://hg.mozilla.org/projects/nss/rev/2e605fde0fa9

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Sorry, had to back this out:

https://hg.mozilla.org/projects/nss/rev/e43f7177f890

https://circleci.com/gh/nss-dev/nss/354

In function ‘memset’,
    inlined from ‘sec_PKCS7Encrypt’ at p7local.c:715:2:
/usr/include/x86_64-linux-gnu/bits/string3.h:81:7: error: call to ‘__warn_memset_zero_len’ declared with attribute warning: memset used with constant zero length parameter; this could be due to transposed parameters [-Werror]
       __warn_memset_zero_len ();
       ^
cc1: all warnings being treated as errors

Comment 4

[Martin Thomson [:mt:]]

We should have backed out Bug 1234510.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/projects/nss/rev/d8064837a36f