1254416 - Urlbar doesn't show suggestions if I paste string in urlbar (in some cases)

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect, P3)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 47, 32bit, ID 20160229030448
STR:
1. Copy string "Unique20160308080329" to clipboard. Open http://example.org/ in a new tab
2. Focus urlbar
3._Paste_ string "Unique20160308080329" in urlbar (Ctrl+V)
  [urlbar suggestions appear]
4. Press Escape to hide suggestions   [string "Unique20160308080329" is displayed in urlbar]
5.A) Press Escape   [string "example.org" is displayed in urlbar]
5.B) Click on the free place on the page. Then focus urlbar again
6. Select all text in urlbar (Ctrl+A)
7._Paste_ string "Unique20160308080329" in urlbar (Ctrl+V)

AR:
  After Step 2 string "example.org" is displayed in urlbar, and it looks focused
  After Step 3 suggestions appear
 Scenario (A):
  After Step 6 string "example.org" is displayed in urlbar, and it looks focused
  After Step 7 suggestions do NOT appear
 Scenario (B):
  After Step 6 string "Unique20160308080329" is displayed in urlbar, and it looks selected
  After Step 7 suggestions do NOT appear

ER:  
 Suggestions should appear at Step 7, at least in scenario (A), because in that scenario
 user sees at Step 6 the same thing as at Step 2, and does the same action. Actually,
 it would be good to see suggestions in scenario (B) as well, because it seems desired behavior

Comment 1

[Marco Bonardo [:mak]]

Seems to WFM in current nightly

Comment 2

[arni2033]

>>>   My Info:   Win7_64, Nightly 52, 32bit, ID 20161017030209 (2016-10-17)
This is reproducible to this day.

STR_2:  (the same as comment 0, actually)
1. Copy string "mozilla" to clipboard. Open a new tab
2._Paste_ string "mozilla" in urlbar (Ctrl+V)   [suggestions appear]
3. Press Escape twice
4._Paste_ string "mozilla" in urlbar (Ctrl+V)

AR:
 Step 3 - suggestions   DO   appear when I paste string in empty urlbar
 Step 5 - suggestions do NOT appear when I paste string in empty urlbar
ER:
 Step 5 - suggestions should appear

Comment 3

[Marco Bonardo [:mak]]

ok, the reason is that we already did that search and the user dismissed it, so we don't run it again. Off-hand I can't tell how hard would be to detect the text changed, if we track reusing a previous result in the controller it should be easy (we can check handleRevert), if we do that in the component, than it's harder.
I'm moving this to P3 to retriage it in the future when we have some available resources.

Comment 4

[Marco Bonardo [:mak]]

We now always run a query