Closed Bug 1254451 Opened 4 years ago Closed 4 years ago
Better document toolchain versions in tooltool manifests
58 bytes, text/x-review-board-request
Currently, we have tooltool manifests containing "clang_version": "rnnnnnn", which is pretty much useless to know what actual version of clang it is. We also have other tooltool manifest containing "version": "gcc 4.9.3", inside the section for gcc.tar.xz, which is, I think, better than the kind-of-global location for the "clang_version" one. And then we have all the undocumented ones (android sdk, ndk...).
linux32/asan.manifest is removed because the file is not in tooltool (anymore?). Review commit: https://reviewboard.mozilla.org/r/38633/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38633/
Attachment #8727755 - Flags: review?(nfroyd)
Comment on attachment 8727755 [details] MozReview Request: Bug 1254451 - Better document toolchain versions in tooltool manifests https://reviewboard.mozilla.org/r/38633/#review35325 Yes please. I don't suppose we have any way of enforcing that folks provide the "version" key when updating packages? Is that feasible?
Attachment #8727755 - Flags: review?(nfroyd) → review+
We could add a simple lint job that checks all the in-tree tooltool manifests or something like that.
I'm not too worried. The clang_version was properly updated. The problem was just that the info was not very useful, and not there for gcc. People changing gcc or clang will now see a different version string format to update and will update it accordingly. And for new tooltool manifests, we usually copy files around. So my bet is that it won't be a problem in practice.
You need to log in before you can comment on or make changes to this bug.