1254451 - Better document toolchain versions in tooltool manifests

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Currently, we have tooltool manifests containing "clang_version": "rnnnnnn", which is pretty much useless to know what actual version of clang it is.
We also have other tooltool manifest containing "version": "gcc 4.9.3", inside the section for gcc.tar.xz, which is, I think, better than the kind-of-global location for the "clang_version" one. And then we have all the undocumented ones (android sdk, ndk...).

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1254451 - Better document toolchain versions in tooltool manifests

linux32/asan.manifest is removed because the file is not in tooltool
(anymore?).

Review commit: https://reviewboard.mozilla.org/r/38633/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38633/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8727755 [details]
MozReview Request: Bug 1254451 - Better document toolchain versions in tooltool manifests

https://reviewboard.mozilla.org/r/38633/#review35325

Yes please.

I don't suppose we have any way of enforcing that folks provide the "version" key when updating packages?  Is that feasible?

Comment 3

[(not currently active) Ted Mielczarek]

We could add a simple lint job that checks all the in-tree tooltool manifests or something like that.

Comment 4

[Mike Hommey [:glandium]]

I'm not too worried. The clang_version was properly updated. The problem was just that the info was not very useful, and not there for gcc. People changing gcc or clang will now see a different version string format to update and will update it accordingly. And for new tooltool manifests, we usually copy files around. So my bet is that it won't be a problem in practice.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/078fdc1a2e27

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/078fdc1a2e27