Closed
Bug 1254452
Opened 8 years ago
Closed 8 years ago
[CID 1247653] Unused value in certutil.c
Categories
(NSS :: Libraries, defect)
NSS
Libraries
Tracking
(firefox48 affected)
RESOLVED
FIXED
3.24
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | affected |
People
(Reporter: dimi, Assigned: dimi)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID1247653)
Attachments
(1 file)
|
910 bytes,
patch
|
franziskus
:
review+
|
Details | Diff | Splinter Review |
rv in outputCertOrExtension is not handled when error wirting extension
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → dlee
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•8 years ago
|
||
Remove |rv = SECSuccess| so outputCertOrExtension will return failure when PR_Write error. But i am not sure if the ALWAYS set SECSuccess is intentional...
Attachment #8727738 -
Flags: review?(franziskuskiefer)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8727738 [details] [diff] [review] Fix unused value Review of attachment 8727738 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #8727738 -
Flags: review?(franziskuskiefer) → review+
|
|
||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/9ff73c1bcd20
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.24
You need to log in
before you can comment on or make changes to this bug.
Description
•