1254477 - [Presentation WebAPI] receiver should always return null for the defaultRequest

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

According to the latest spec:

A user agent that is a receiving user agent but not a controlling user agent MUST always return null for the defaultRequest attribute. It MUST treat setting the defaultRequest attribute as a no-op.

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

We can either check the 'mReceiver' in Presentation object or use the role introduced in bug 1234492.

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Return null for defaultRequest

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8756718 [details] [diff] [review]
Return null for defaultRequest

I think the spec should be clearer about what happens when the attribute is set on receiving side. Like mention that the operation is no-op.

Comment 4

[Kershaw Chang [:kershaw]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea4f9ace31b5

Comment 5

[Kershaw Chang [:kershaw]]

(In reply to Olli Pettay [:smaug] from comment #3)
> Comment on attachment 8756718 [details] [diff] [review]
> Return null for defaultRequest
> 
> I think the spec should be clearer about what happens when the attribute is
> set on receiving side. Like mention that the operation is no-op.

Thanks for reviewing.

As comment #0 said, the spec do mention this.

Comment 6

[Kershaw Chang [:kershaw]]

Attachment: Return null for defaultRequest, r=smaug

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4a5ef2ca595

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d4a5ef2ca595

Comment 9

[Kershaw Chang [:kershaw]]

Josh, please help to approve. Thanks.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Presentation API
User impact if declined: The behavior of presentation defaultRequest cannot be aligned with spec.
Testing completed: with automation test
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: n/a

Comment 10

[Josh Cheng [:josh]]

Comment on attachment 8756894 [details] [diff] [review]
Return null for defaultRequest, r=smaug

Approve for TV 2.6

Comment 11

[Gary Chen [:xeonchen]]

https://github.com/mozilla-b2g/gecko-b2g/commit/cbfb889346d87b01c43cece070c13c2064bc40bb