1254493 - Remove Code2000 and Arial Unicode MS from prefs

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

Code2000 is no longer legally available. Arial Unicode MS is in the common fallback, so there is no point in adding it in prefs.
Moreover, they will prevent some scripts from selecting more appropriate fonts.

Comment 1

[Jonathan Kew [:jfkthame]]

Comment on attachment 8727794 [details] [diff] [review]
patch

Review of attachment 8727794 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ +3041,5 @@
>  pref("font.name-list.sans-serif.x-devanagari", "Nirmala UI, Mangal");
>  pref("font.name-list.monospace.x-devanagari", "Mangal, Nirmala UI");
>  
>  pref("font.name.serif.x-tamil", "Latha");
> +pref("font.name.sans-serif.x-tamil", "Arial");

I don't think it makes sense to specify Arial here; AFAIK, it doesn't have any Tamil support. If Latha is the only Tamil font shipped by default, better to just specify that for both serif and sans-serif, I think.

@@ +3089,3 @@
>  
>  pref("font.name.serif.x-guru", "Raavi");
> +pref("font.name.sans-serif.x-guru", "Arial");

Again, Arial doesn't make sense here AFAICS.

Comment 2

[Masatoshi Kimura [:emk]]

(In reply to Jonathan Kew (:jfkthame) from comment #1)
> >  pref("font.name.serif.x-tamil", "Latha");
> > +pref("font.name.sans-serif.x-tamil", "Arial");
> 
> I don't think it makes sense to specify Arial here; AFAIK, it doesn't have
> any Tamil support. If Latha is the only Tamil font shipped by default,
> better to just specify that for both serif and sans-serif, I think.

I tried to preserve the current behavior as much as possible. Given the common fallback, "font.name-list.sans-serif.x-tamil" virtually has "Arial, Arial Unicode MS" at the bottom of the list. Therefore I picked a font from the top of the list. Let's talk about the behavior change in another bug (e.g. bug 1131441).
Also, My Windows 10 system did not have "Latha".

> >  pref("font.name.serif.x-guru", "Raavi");
> > +pref("font.name.sans-serif.x-guru", "Arial");
> 
> Again, Arial doesn't make sense here AFAICS.

Same as above.

Comment 3

[Jonathan Kew [:jfkthame]]

Comment on attachment 8727794 [details] [diff] [review]
patch

OK, I guess that's fine.

I see that Latha, etc., are in the optional Supplemental Fonts packages on Win10, so yes, they'll only be installed if the user chooses. (Otherwise, most of the Indic scripts will just end up with Nirmala UI.)

Comment 4

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d506fc68f5caa17320efb23f87e0ca3c0457c734
Bug 1254493 - Remove Code2000 and Arial Unicode MS from prefs. r=jfkthame

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d506fc68f5ca