125452 - Space shouldn't advance message when message pane collapsed

Status: RESOLVED EXPIRED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail]]

Using Build ID: 2002021303
Steps to reproduce problem
1. Open a folder with some unread messages
2. Collapse the message pane
3. Press Space

Expected results: nothing happens

Actual results: selection advances to next unread message

Comment 1

[[e-mail]]

Attachment: Proposed patch

I also added a check for MailAreaHasFocus in case the focus is in an input.

Comment 2

[laurel]

Info:  4.x advanced to next unread via spacebar when message pane collapsed.  

Comment 3

[(not reading, please use [e-mail] instead)]

jglick, do we want the 4.x behaviour (http://bugzilla.mozilla.org/show_bug.cgi?
id=125452#c2) or what neil is suggesting?

Comment 4

[jglick]

Neil, is there a reason you don't want Space to advanced to next unread message? 
Users with the message pane closed can still use the Spacebar to advance to the 
next unread msg and Enter to open the message.

Comment 5

[[e-mail]]

I thought that space was for scrolling the message and is therefore
inappropriate if no message is currently displayed.

Comment 6

[jglick]

>I thought that space was for scrolling the message and is therefore
>inappropriate if no message is currently displayed.

If focus is in the Message Pane, yes, spacebar scrolls. But once it reaches the 
end of message, it shifts focus to Thread Pane and jumps to Next Unread msg - 
that seems odd. ("N" already does this)
If focus is in Thread Pane, it jumps to next unread msg.
If focus is in the Folder Pane, it it shifts focus to Thread Pane and jumps to 
Next Unread msg - that seems odd. ("N" already does this)

If spacebar is going to do diff things in diff panes (scroll message vs jump to 
next unread), i don't think its good that it also sometimes switches focus 
between panes.

Comment 7

[[e-mail]]

Actually I see space scrolling the message whatever the focus...

Comment 8

[jglick]

Ouch, thats not so good. I start with focus in the Thead Pane, click the scroll 
bar and focus jumps to the message pane and scrolls the message. Once it reaches 
the end of the message, it jumps to the Thread pane and selects the Next Unread 
msg and additional spacebar hits cause it to continue to jump to the Next Unread 
msg in Thread Pane.

If focus starts in Thread Pane, it jumps to next unread msg.

If focus starts in the Folder Pane, it it shifts focus to Thread Pane and jumps 
to Next Unread msg - that seems odd. ("N" already does this).

Like i said above, if spacebar is going to do diff things in diff panes (scroll 
message vs jump to next unread), i don't think its good that it also sometimes 
switches focus between panes.

Comment 9

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 10

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420