1254520 - Opening your own room link should have a functional test

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Mark Banner (:standard8)]

We don't have a test for if you attempt to open one of your own room links to check that the page shows you the special page to open your room in the conversation window.

We should create a new test for this, see the user story.

Comment 1

[GitHub Autolander Bot]

Attachment: [loop] mancas:bug1254520 > mozilla:master

Comment 2

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8733315 [details] [review]
[loop] mancas:bug1254520 > mozilla:master

Hey Mark, I've created a new file for helper functions and a file per each test as you suggested on IRC. I'd like if you could take a quick look a give me feedback before continue working on that, that way, the final review will be easier.

Besides, I have doubts about how to set "loop.linkClicker.url" pref to the standalone url

Thanks

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8733315 [details] [review]
[loop] mancas:bug1254520 > mozilla:master

Thanks, it is a good start. I think, like I commented on the PR, we should use python's inheritance facilities to make things a bit simpler here.

Comment 4

[Manuel Casas Barrado [:mancas]]

PR updated using python's inheritance as you suggested. Works fine. However I face to another problem, the FTU is not shown in the second test so I'm trying to restore the localStorage by executing a script but I'm getting this error: 

JavascriptException: [Exception... "Component is not available"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)" thoughts?

Also, can you tell me how how to set the required pref for this test?

Comment 5

[Mark Banner (:standard8)]

(In reply to Manuel Casas Barrado [:mancas] from comment #4)
> PR updated using python's inheritance as you suggested. Works fine. However
> I face to another problem, the FTU is not shown in the second test so I'm
> trying to restore the localStorage by executing a script but I'm getting
> this error: 
> 
> JavascriptException: [Exception... "Component is not available"  nsresult:
> "0x80040111 (NS_ERROR_NOT_AVAILABLE)" thoughts?

I'm not sure you'll need to reset the local storage once you've done the pref change, however, a thought would be not to reset it, and just account for that in the second run of the test (i.e. the link clicker ftu wouldn't be displayed).

> Also, can you tell me how how to set the required pref for this test?

In the Test2Linkclicker#setup function, you want to change FIREFOX_PREFERENCES with the value you need for loop.linkClicker.url - you probably want to clone FIREFOX_PREFERENCES first to avoid affecting other tests.

I think you need to set the pref to `CONTENT_SERVER_URL + "/"` (import CONTENT_SERVER_URL from config.py as well).

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8733315 [details] [review]
[loop] mancas:bug1254520 > mozilla:master

I think I'd prefer a bit more code in the shared files, however, this is a great start and gains us more coverage, so I think we should land it as-is with the couple of comments that I put in the PR fixed.

Note: there's a bit of bitrot from Fernando's patch for ending the call, but I think that should be simplish to resolve.

r=Standard8

Comment 7

[Manuel Casas Barrado [:mancas]]

Landed in  master: https://github.com/mozilla/loop/commit/7c6e971193756009b605fb35a3154c3328bd24e6