Closed
Bug 1254521
Opened 8 years ago
Closed 8 years ago
Fix API documentation for a number of element module interfaces
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox47 fixed, firefox48 fixed)
RESOLVED
FIXED
mozilla48
People
(Reporter: ato, Assigned: ato)
Details
(Keywords: pi-marionette-server)
Attachments
(2 files)
No description provided.
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Comment 1•8 years ago
|
||
Both element.inViewport and element.isVisible needs fixes.
Summary: Add return API documentation for element.isVisible → Fix API documentation for a number of element module interfaces
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/38655/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38655/
Attachment #8727819 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/38657/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38657/
Attachment #8727820 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Comment on attachment 8727819 [details] MozReview Request: Bug 1254521 - Add return type docs for element.isVisible; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38655/diff/1-2/
Attachment #8727819 -
Attachment description: MozReview Request: Bug 1254521 - Add return type docs for element.inViewport; r?automatedtester → MozReview Request: Bug 1254521 - Add return type docs for element.isVisible; r?automatedtester
|
|
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 8727820 [details] MozReview Request: Bug 1254521 - Add return type docs for element.inViewport; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38657/diff/1-2/
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8727819 [details] MozReview Request: Bug 1254521 - Add return type docs for element.isVisible; r?automatedtester https://reviewboard.mozilla.org/r/38655/#review35361
Attachment #8727819 -
Flags: review?(dburns) → review+
|
|
||
Comment 7•8 years ago
|
||
Comment on attachment 8727820 [details] MozReview Request: Bug 1254521 - Add return type docs for element.inViewport; r?automatedtester https://reviewboard.mozilla.org/r/38657/#review35363
Attachment #8727820 -
Flags: review?(dburns) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b53b8707290 https://hg.mozilla.org/integration/mozilla-inbound/rev/16448c5d4d17
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0b53b8707290 https://hg.mozilla.org/mozilla-central/rev/16448c5d4d17
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
|
|
||
Comment 10•8 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-aurora/rev/f46e839eb42e https://hg.mozilla.org/releases/mozilla-aurora/rev/7055469046c5
status-firefox47:
--- → fixed
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•