Closed Bug 1254521 Opened 7 years ago Closed 7 years ago

Fix API documentation for a number of element module interfaces

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox47 fixed, firefox48 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

(Keywords: pi-marionette-server)

Attachments

(2 files)

MozReview Request: Bug 1254521 - Add return type docs for element.isVisible; r?automatedtester
58 bytes, text/x-review-board-request
automatedtester
: review+
Details
MozReview Request: Bug 1254521 - Add return type docs for element.inViewport; r?automatedtester
58 bytes, text/x-review-board-request
automatedtester
: review+
Details 
      No description provided.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Keywords: ateam-marionette-server
Both element.inViewport and element.isVisible needs fixes.
Summary: Add return API documentation for element.isVisible → Fix API documentation for a number of element module interfaces
Comment on attachment 8727819 [details]
MozReview Request: Bug 1254521 - Add return type docs for element.isVisible; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38655/diff/1-2/
Attachment #8727819 - Attachment description: MozReview Request: Bug 1254521 - Add return type docs for element.inViewport; r?automatedtester → MozReview Request: Bug 1254521 - Add return type docs for element.isVisible; r?automatedtester
Comment on attachment 8727820 [details]
MozReview Request: Bug 1254521 - Add return type docs for element.inViewport; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38657/diff/1-2/
Comment on attachment 8727819 [details]
MozReview Request: Bug 1254521 - Add return type docs for element.isVisible; r?automatedtester

https://reviewboard.mozilla.org/r/38655/#review35361
Attachment #8727819 - Flags: review?(dburns) → review+
Comment on attachment 8727820 [details]
MozReview Request: Bug 1254521 - Add return type docs for element.inViewport; r?automatedtester

https://reviewboard.mozilla.org/r/38657/#review35363
Attachment #8727820 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/0b53b8707290
https://hg.mozilla.org/mozilla-central/rev/16448c5d4d17
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.