Closed
Bug 1254523
Opened 8 years ago
Closed 8 years ago
Convert modal.Dialog to a class
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
(Keywords: pi-marionette-server)
Attachments
(2 files)
The ES6 class pattern would naturally apply to modal.Dialog.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → ato
Keywords: ateam-marionette-server
|
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/38661/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38661/
Attachment #8727828 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/38663/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38663/
Attachment #8727829 -
Flags: review?(dburns)
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8727828 [details] MozReview Request: Bug 1254523 - Use constants for Cu and isFirefox; r?automatedtester https://reviewboard.mozilla.org/r/38661/#review35795
Attachment #8727828 -
Flags: review?(dburns) → review+
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8727829 [details] MozReview Request: Bug 1254523 - Convert modal.Dialog to a class; r?automatedtester https://reviewboard.mozilla.org/r/38663/#review35797
Attachment #8727829 -
Flags: review?(dburns) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/85992f47a30e https://hg.mozilla.org/integration/mozilla-inbound/rev/5b71cda57c27
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/85992f47a30e https://hg.mozilla.org/mozilla-central/rev/5b71cda57c27
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•