Convert modal.Dialog to a class

RESOLVED FIXED in Firefox 48

Status

Testing
Marionette
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

({ateam-marionette-server})

Version 3
mozilla48
ateam-marionette-server
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
The ES6 class pattern would naturally apply to modal.Dialog.
(Assignee)

Updated

2 years ago
Assignee: nobody → ato
Keywords: ateam-marionette-server
(Assignee)

Comment 1

2 years ago
Created attachment 8727828 [details]
MozReview Request: Bug 1254523 - Use constants for Cu and isFirefox; r?automatedtester

Review commit: https://reviewboard.mozilla.org/r/38661/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38661/
Attachment #8727828 - Flags: review?(dburns)
(Assignee)

Comment 2

2 years ago
Created attachment 8727829 [details]
MozReview Request: Bug 1254523 - Convert modal.Dialog to a class; r?automatedtester

Review commit: https://reviewboard.mozilla.org/r/38663/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38663/
Attachment #8727829 - Flags: review?(dburns)
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
Comment on attachment 8727828 [details]
MozReview Request: Bug 1254523 - Use constants for Cu and isFirefox; r?automatedtester

https://reviewboard.mozilla.org/r/38661/#review35795
Attachment #8727828 - Flags: review?(dburns) → review+
Comment on attachment 8727829 [details]
MozReview Request: Bug 1254523 - Convert modal.Dialog to a class; r?automatedtester

https://reviewboard.mozilla.org/r/38663/#review35797
Attachment #8727829 - Flags: review?(dburns) → review+

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/85992f47a30e
https://hg.mozilla.org/mozilla-central/rev/5b71cda57c27
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.