Disable b2g-ota automation

RESOLVED FIXED

Status

Release Engineering
Buildduty
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: catlee, Assigned: vladC)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments, 3 obsolete attachments)

(Reporter)

Description

2 years ago
This includes all buildbot support, b2g bumper, and any other automation.
(Assignee)

Updated

2 years ago
Assignee: nobody → vlad.ciobancai
Created attachment 8729518 [details] [diff] [review]
bug1254549_buildbot-configs.patch

Attached you can find the patch to disable b2g-ota from buildbot configs repository
Attachment #8729518 - Flags: review?(kmoir)
Created attachment 8729519 [details]
bug1254549_output

Attached the differences
Created attachment 8729520 [details] [diff] [review]
bug1254549_production-branches.patch

Attached you can find the patch that remove b2g-ota from production-branches
Attachment #8729520 - Flags: review?(kmoir)
Created attachment 8729521 [details] [diff] [review]
bug1254549_buildbotcustom_common.patch
Attachment #8729521 - Flags: review?(kmoir)

Updated

2 years ago
Attachment #8729518 - Flags: review?(kmoir) → review+

Updated

2 years ago
Attachment #8729520 - Flags: review?(kmoir) → review+

Updated

2 years ago
Attachment #8729521 - Flags: review?(kmoir) → review+
Created attachment 8729536 [details]
bug1254549_test-master.output

Attached you can find the output for test-master.sh script 

Kim I would like to ask you help about the errors that I'm receiving
Flags: needinfo?(kmoir)
(In reply to Vlad Ciobancai [:vladC] from comment #5)
> Created attachment 8729536 [details]
> bug1254549_test-master.output
> 
> Attached you can find the output for test-master.sh script 
> 
> Kim I would like to ask you help about the errors that I'm receiving

I run the script without my changes (like a buildbotmaster fresh) and I'm still receiving the same error.

Comment 7

2 years ago
It looks like you need to disable the builds for b2g-ota too, not just the tests.  There are still references in mozilla/config.py on your master.

catlee also mentions in the intial bug description the b2g bumper support needs to be removed too
https://wiki.mozilla.org/ReleaseEngineering/Applications/Bumper
Flags: needinfo?(kmoir)

Comment 8

2 years ago
not sure what is causing the problem on a fresh master, let me look
(In reply to Kim Moir [:kmoir] from comment #7)
> It looks like you need to disable the builds for b2g-ota too, not just the
> tests.  There are still references in mozilla/config.py on your master.


I think when you checked my master the buildbot-configs have been reverted to test the test-master.sh with a fresh buildbotmaster. The attachment 8729518 [details] [diff] [review] contains the change
Created attachment 8732891 [details]
bug1254549_test-master.output

After I re-created the master and applied again the patches , the tests passed (attached the output from my master)
Attachment #8729536 - Attachment is obsolete: true
Created attachment 8732935 [details] [diff] [review]
bug1254549_mozharness.patch

Attached you can find the patch where I removed b2g-ota from bumper

@Kim do you know if there;s anything else to remove. I searched for b2g-ota but I didn't found 

The patches have been tested and the output is attached as attachment 8732891 [details]
Attachment #8732935 - Flags: review?(kmoir)
Comment on attachment 8732935 [details] [diff] [review]
bug1254549_mozharness.patch

I think this is okay but adding hwine as a reviewer since is more familiar with the bumper code
Attachment #8732935 - Flags: review?(kmoir) → review+

Updated

2 years ago
Attachment #8732935 - Flags: review+ → review?(hwine)
Comment on attachment 8732935 [details] [diff] [review]
bug1254549_mozharness.patch

Review of attachment 8732935 [details] [diff] [review]:
-----------------------------------------------------------------

Nothing in config/vcssync should be touched for this bug, so r- on beagle.py change (We won't undo that until the b2g-ota repositories are deleted.)

The b2g_bumper config removal is proper. The b2g_bumper driver script iterates over all *.py files in b2g_bumper/config, so deletion of the file will do what is intended (stop bumping b2g-ota changes). r+ on the b2g-ota.py change

Please resubmit with just the b2g-ota.py removal for a quick review.
Attachment #8732935 - Flags: review?(hwine) → review-
Created attachment 8733271 [details] [diff] [review]
bug1254549_mozharness.patch

Updated the patch using the suggestion that you provided
Attachment #8732935 - Attachment is obsolete: true
Attachment #8733271 - Flags: review?(hwine)
Comment on attachment 8733271 [details] [diff] [review]
bug1254549_mozharness.patch

Review of attachment 8733271 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm - thanks!
Attachment #8733271 - Flags: review?(hwine) → review+
(Assignee)

Updated

2 years ago
Attachment #8729518 - Flags: checked-in+
(Assignee)

Updated

2 years ago
Attachment #8729520 - Flags: checked-in+
(Assignee)

Updated

2 years ago
Attachment #8729521 - Flags: checked-in+
(Assignee)

Updated

2 years ago
Attachment #8733271 - Flags: checked-in+
(Assignee)

Updated

2 years ago
Attachment #8729518 - Flags: checked-in+
Created attachment 8733886 [details] [diff] [review]
bug1254549_buildbot-configs.patch

I re-created the patch in order to remove the conflicts
Attachment #8729518 - Attachment is obsolete: true
Attachment #8733886 - Flags: review?(kmoir)

Updated

2 years ago
Attachment #8733886 - Flags: review?(kmoir) → review+
Changes pushed in production
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.